Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1682 closed Bug (fixed)

AssetManager: css merging not properly handling relative paths containing . or ..

Reported by: vipsoft Owned by:
Priority: major Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

I installed piwik in a directory, 2 levels down from the web server's document root, i.e., /var/www/one/two/, and I'm getting a number of 404 errors, e.g., GET /themes/default/images/xxx, when it should be /one/two/themes/default/images/xxx.

In asset_manager_global_css.css, I see:

url(../../themes/default/./images/xxx)

This should be either:

url(./themes/default/images/xxx)
url(themes/default/images/xxx)

Change History (4)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Summary changed from css minifier not properly handling relative paths containing . or .. to AssetManager: css merging not properly handling relative paths containing . or ..

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3101]) fixes #1682

comment:3 Changed 4 years ago by vipsoft (robocoder)

(In [3102]) refs #1682 - path consistency

comment:4 Changed 4 years ago by vipsoft (robocoder)

(In [3104]) refs #1682 - use realpath to remove ..

Note: See TracTickets for help on using tickets.