Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetManager: css merging not properly handling relative paths containing . or .. #1682

Closed
robocoder opened this issue Sep 8, 2010 · 3 comments
Closed

AssetManager: css merging not properly handling relative paths containing . or .. #1682

robocoder opened this issue Sep 8, 2010 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.1

Comments

@robocoder
Copy link
Contributor

I installed piwik in a directory, 2 levels down from the web server's document root, i.e., /var/www/one/two/, and I'm getting a number of 404 errors, e.g., GET /themes/default/images/xxx, when it should be /one/two/themes/default/images/xxx.

In asset_manager_global_css.css, I see:

url(../../themes/default/./images/xxx)

This should be either:

url(./themes/default/images/xxx)
url(themes/default/images/xxx)
@robocoder
Copy link
Contributor Author

(In [3101]) fixes #1682

@robocoder
Copy link
Contributor Author

(In [3102]) refs #1682 - path consistency

@robocoder
Copy link
Contributor Author

(In [3104]) refs #1682 - use realpath to remove ..

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@robocoder