Opened 4 years ago

Closed 3 years ago

#1751 closed Task (fixed)

piwik.js: refactoring trackGoal, trackPageView, and trackLink

Reported by: vipsoft Owned by: vipsoft
Priority: normal Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

trackGoal and trackPageView both send page view and browser settings. Since it's conceivable that both might be called on the same page, we can optimize piwik.js to only send the payload once per page.

Propose: send the payload once for trackPageView(), trackGoal(), and trackLink(), unless setCustomUrl() or setReferrerUrl() are called. As a side effect, this should allow for additional refactoring that reduces the size of piwik.js.

Change History (6)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3224]) fixes #1751

comment:2 Changed 4 years ago by vipsoft (robocoder)

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from piwik.js: duplicate data may be sent per page view to piwik.js: refactoring trackGoal, trackPageView, and trackLink
  • Type changed from New feature to Task

comment:3 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3238]) fixes #1751 - always includes page info and browser settings in payload in case of race conditions (erring on the side of caution)

comment:4 Changed 3 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

so nothing really happened in this ticket correct? shall we close it as 'wontfix' ?

comment:5 Changed 3 years ago by vipsoft (robocoder)

there were changes...just not as I originally proposed, ie previously only trackpageview and trackgoal would attach the browser settings payload; now, tracklink does too

and there was refactoring for consistency (thus smaller piwik.js)

comment:6 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from reopened to closed

sounds good!

Note: See TracTickets for help on using tickets.