Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalized domain names and ccTLDs #1755

Closed
robocoder opened this issue Oct 6, 2010 · 3 comments
Closed

Internationalized domain names and ccTLDs #1755

robocoder opened this issue Oct 6, 2010 · 3 comments
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@robocoder
Copy link
Contributor

Make sure we support internationalized domain names and ccTLDs by adding more unit tests. (Areas include provider, sitesmanager.addsite, and searchengine detection for {}.)

China (.cn):

  • . / .xn--fiqs8S
  • . / .xn--fiqz9S
    Egypt (.eg):
  • . / .xn--wgbh1c
    Hong Kong (.hk):
  • . / .xn--j6w193g
    India (.in):
  • . / .xn--h2brj9c
  • . / .xn--mgbbh1a71e
  • . / .xn--fpcrj9c3d
  • . / xn--gecrj9c
  • . / .xn--s9brj9c
  • . / .xn--xkc2dl3a5ee0h
  • . / .xn--45brj9c
    Iran (.ir):
  • / .xn--mgba3a4f16a
  • / .xn--mgba3a4fra
    Jordan (.jo):
  • . /.xn--mgbayh7gpa
    Korea (.kr):
  • . /.xn--3e0b707e
    Palestine (.ps):
  • . / .xn--ygbi2ammx
    Qatar (.qa):
  • . / .xn--wgbl6a
    Russia (.ru):
  • . / .xn--p1ai
    Saudi Arabia (.sa):
  • . / .xn--mgberp4a5d4ar
  • . / xn--mgberp4a5d4a87g
  • . / .xn--mgbqly7c0a67fbc
  • . / .xn--mgbqly7cvafr
    Singapore (.sg):
  • . / .xn--yfro4i67o
  • . / .xn--clchc0ea0b2g2a9gcd
    Sri Lanka (.lk):
  • . / .xn--fzc2c9e2c
  • . / .xn--xkc2al3hye2a
    Syria (.sy):
  • . / .xn--ogbpf8fl
  • . / .xn--mgbtf8fl
    Taiwan (.tw):
  • . / .xn--kpry57d
  • . / .xn--kprw13d
    Thailand (.th):
  • . / .xn--o3cw4h
    Tunisia (.tn):
  • . / .xn--pgbs0dh
    United Arab Emirates (.ae):
  • . / .xn--mgbaam7a8h

Also, an opportunity to provide support or Punycode URLs was raised in #1073, but never implemented.

References:

@anonymous-matomo-user
Copy link

Same feature request for IDN in .com TLD zone. Forum post [http://forum.piwik.org/read.php?2,77579,77664]

Domain name for IDN .com and as punycode looks like xn--80aeqbhthr9b.com

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. and removed c: Plugins Wishlist labels Oct 12, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@magiruuvelvet
Copy link

magiruuvelvet commented Dec 19, 2016

Not sure if I should add this here, but before opening a new issue. I temporarily worked around the email address validation by returing always true in core/Piwik.php@isValidEmailString. I know this is nasty but I have a IDN domain and Piwik refused to accept my valid and working e-mail address. After applying this patch I finally got piwik to send reports and it worked great without problems.

Just want to let you guys know.

@mattab
Copy link
Member

mattab commented Dec 25, 2016

@magiruuvelvet a few months ago we tried to detect these issues. We added an automated tests which tests our email validation logic against the list of valid domain name extensions as per IANA in http://data.iana.org/TLD/tlds-alpha-by-domain.txt

This was done in #9674

so if you still experience an issue in PIwik 3, please create a new issue

@mattab mattab closed this as completed Dec 25, 2016
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

4 participants