New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piwik::checkValidLoginString(): allow "@" in login #1762
Comments
Fixing this bug is really easy : core/Piwik.php, line 1595 replace: && (preg_match('/^[A-Za-z0-9_.-]*$/', $userLogin) > 0)) By && (preg_match('/^[@A-Za-z0-9_.-]*$/', $userLogin) > 0)) |
(I've tested it and it works great) |
re: LDAP. Is this change necessary, given the LDAP plugin in #734? |
I guess it is because it looks like the http_auth plugin is more interesting anyway. Ldap is only use to do authentification, piwik still do the authorization. Comments in the bug related to the http_auth plugin seems to think the same;-) |
increasing priority, as it makes sense to allow @ in logins |
(In [3381]) Fixes #1762 |
(In [3388]) refs #1762 - fix unit test |
Currently, piwik explicitely forbid use of "@" in a user login. (only [a-zA-Z0-9-._] are allowed )
It doesn't make much sense to forbid the "@" and it make it impossible to integrate piwik with any service where the login is the email (such as lot of LDAP setup).
The text was updated successfully, but these errors were encountered: