Opened 4 years ago

Closed 4 years ago

#1763 closed Bug (fixed)

div element not closed in several widgets

Reported by: wil Owned by:
Priority: normal Milestone: Piwik 1.1
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

We implemented several widgets of Piwik 1.0 on our website in their respective iframes. Because we weren't happy with the iframes, we created a script that reads out the content of the iframes (without html, head and body tags) and pasted those on our page.

All widget sources were pasted below each other. This resulted somehow in almost each div.widget being nested in the previous widget.

After careful consideration, I can only come to the conclusion that in most of the widgets, the div.widget isn't closed. I ran one of the iframe contents through the W3C html validator, which resulted in this conclusion.

On our page, I've manually closed the following widgets with a </div>, which fixed our problem:

  • VisitSummarygetEvolutionGraph
  • ReferersgetKeywords
  • ReferersgetWebsites
  • ReferersgetSearchEngines
  • VisitorInterestgetNumberofVisitsPerVisitDuration
  • UserCountrygetCountry
  • ActionsgetPageTitles

Change History (4)

comment:1 Changed 4 years ago by vipsoft (robocoder)

  • Keywords division div widget removed
  • Summary changed from Division not closed in several widgets to div element not closed in several widgets

comment:2 Changed 4 years ago by SteveG (sgiehl)

(In [3245]) refs #1763 maybe that should fix the issue

comment:3 Changed 4 years ago by vipsoft (robocoder)

Probably because the original doctype was stripped off.

wil: please confirm so we can close.

comment:4 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

Closing as the reporter didn't register with an email address.

Note: See TracTickets for help on using tickets.