Opened 3 years ago

Closed 3 years ago

#1786 closed Bug (fixed)

Undo double encoding: html entities doesn't show correctly in Page titles widget

Reported by: machoyer Owned by:
Priority: low Milestone: Piwik 1.1
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

If there are html entities (i.g. ö ) in title tag of tracked page,the entities sometimes doesn't show correctly in Page titles widget. Please look in attachement.
Maybe a html_entity_decode is missing.

Greetings
machoyer

Attachments (1)

screen-capture.png (93.7 KB) - added by machoyer 3 years ago.
Page titles widget

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by machoyer

Page titles widget

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Keywords html entities removed
  • Milestone set to 1.1 - Piwik 1.1
  • Summary changed from html entities doesn't show correctly in Page titles widget to Undo double encoding: html entities doesn't show correctly in Page titles widget

The ampersand is encodeURIComponent()'d for transmission. This would actually require getRequestVar() to sanitize with something like:

$x = htmlspecialchars(html_entity_decode(htmlspecialchars_decode($x)));

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3276]) fixes #1786

Note: See TracTickets for help on using tickets.