Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik.js: use blacklist file extensions instead of white list #1796

Closed
robocoder opened this issue Nov 2, 2010 · 1 comment
Closed

piwik.js: use blacklist file extensions instead of white list #1796

robocoder opened this issue Nov 2, 2010 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

In retrospect, this shouldn't have been a whitelist. We should have implemented a blacklist of extensions that typically represented non-downloads, eg

.php, .html, .asp, ... (and common variants of these)

as there are fewer extensions, less subject to change, and web frameworks move towards friendlier URLs.
@mattab
Copy link
Member

mattab commented Sep 17, 2011

White list is good, since some sites use custom file extension which would track a lot of fake downloads and slow down their site (since download has a delay of 500ms).

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder mentioned this issue Nov 23, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder