Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1814 closed New feature (fixed)

Use ZipArchive when available

Reported by: vipsoft Owned by:
Priority: normal Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

We should use the native 'zip' extension when available (instead of PclZip) because it's faster.

See WordPress wp-admin/includes/file.php unzip_file() wrapper, and _unzip_file_ziparchive() implementation.

Change History (5)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Milestone changed from Plugin Repository to 1.1 - Piwik 1.1
  • Summary changed from ZipArchive to Use ZipArchive when available

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3312]) fixes #1814

comment:3 Changed 3 years ago by vipsoft (robocoder)

(In [3313]) refs #1814 - add another test to make sure the factory method works

comment:4 Changed 3 years ago by matt (mattab)

Anthon, can you please confirm that both use cases have been tested with auto update? is the new auto-update webtest covering one use case already maybe?

comment:5 Changed 3 years ago by vipsoft (robocoder)

  • Type changed from Bug to New feature

Unit tests cover the actual unzipping for both implementations.
Webtest covers the high level use case, as the underlying implementation has been abstracted.

Note: See TracTickets for help on using tickets.