Opened 3 years ago

Closed 3 years ago

#1832 closed Bug (fixed)

API methods: format_limit vs limit inconsistency

Reported by: vipsoft Owned by:
Priority: normal Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

There are API methods in Live and SitesManager that take 'limit" instead of 'format_limit'.

Propose:

  • change these methods to instead accept format_limit; we can getRequestVar('limit') for backward compatibility

Change History (6)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to wontfix
  • Status changed from new to closed

On second thought, format_limit doesn't appear in any other method signatures, and it would be a compat buster to simply remove 'limit' from the parameter list.

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Milestone changed from 1.2 - Piwik 1.2 to 1.1 - Piwik 1.1

comment:3 Changed 3 years ago by vipsoft (robocoder)

(In [3363]) fixes #1706, refs #1832 - allow filter_limit to override default limit; provides API consistency

comment:5 Changed 3 years ago by matt (mattab)

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:6 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3479]) Fixes #1832, Fixes #1873

Note: See TracTickets for help on using tickets.