Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API methods: format_limit vs limit inconsistency #1832

Closed
robocoder opened this issue Nov 23, 2010 · 4 comments
Closed

API methods: format_limit vs limit inconsistency #1832

robocoder opened this issue Nov 23, 2010 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.1

Comments

@robocoder
Copy link
Contributor

There are API methods in Live and SitesManager that take 'limit" instead of 'format_limit'.

Propose:

  • change these methods to instead accept format_limit; we can getRequestVar('limit') for backward compatibility
@robocoder
Copy link
Contributor Author

On second thought, format_limit doesn't appear in any other method signatures, and it would be a compat buster to simply remove 'limit' from the parameter list.

@robocoder
Copy link
Contributor Author

(In [3363]) fixes #1706, refs #1832 - allow filter_limit to override default limit; provides API consistency

@robocoder
Copy link
Contributor Author

(In [3380]) refs #1706, refs #1832

@mattab
Copy link
Member

mattab commented Dec 21, 2010

(In [3479]) Fixes #1832, Fixes #1873

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
@mattab mattab mentioned this issue Dec 21, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@mattab @robocoder