Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFC: JSON parse error for large revenues #1847

Closed
tgr opened this issue Nov 30, 2010 · 6 comments
Closed

OFC: JSON parse error for large revenues #1847

tgr opened this issue Nov 30, 2010 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
1.x

Comments

@tgr
Copy link

tgr commented Nov 30, 2010

If the detailed revenue data (select Goals from the main menu, select a goal, click on the sparkline with "XXXX overall revenue" written after it) has large enough numbers, they will be sent in scientific notation, and the parser will throw up this message and fail to load:

JSON Parse Error [Bad Object]
Error at character 3927, line 80:
@robocoder
Copy link
Contributor

We ran into a similar problem in #839 and reported it upstream to the OFC dev. (The workaround was to cast to int ... which is ok for ranges.)

Perhaps we can fix this in our fork of OFC?

@robocoder
Copy link
Contributor

Maybe we can merge up with the "community release" at http://code.google.com/p/ofc-etw (appears to have the blessing of the original OFC dev).

@tgr
Copy link
Author

tgr commented Dec 7, 2010

This is the relevant OFC-ETW bug: #24 JSON parse error for scientfic notation

@robocoder
Copy link
Contributor

Reprioritizing as this is more a symptom of #1882.

@mattab
Copy link
Member

mattab commented Jan 16, 2011

wont fix, better reopen #1882 if need be (should we?)

@robocoder
Copy link
Contributor

The bug in OFC is that it generally can't parse scientific notation. Something small like 1.0+e01 would trigger the error. IIRC we worked around something similar (prior to the OFC-etw fork).

I'm also vaguely recalling a bug with locales and commas. It would be nice to have at least this ticket or #1882 open as a reminder for further investigation.

@tgr tgr added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
@tgr tgr added T: Bug labels Jul 8, 2014
@tgr tgr mentioned this issue Dec 20, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
3 participants
@tgr @mattab @robocoder