Opened 3 years ago

Closed 3 years ago

#1920 closed Bug (fixed)

Handle X-Forwarded-For misconfiguration

Reported by: vipsoft Owned by:
Priority: normal Milestone: Piwik 1.1
Component: Core Keywords:
Cc: Sensitive: no

Description

On the PHP side, we might see:

$_SERVER['HTTP_X_FORWARDED_FOR'] contains "A.B.C.D, E.F.G.H"
while
$_SERVER['REMOTE_ADDR'] also contains "E.F.G.H".

Propose: modify getLastElementFromList() to skip over IP that duplicates REMOTE_ADDR.

Change History (1)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3547]) fixes #1920 - also removes deprecated getFirstElementFromList (formerly getFirstIpFromList)

Note: See TracTickets for help on using tickets.