Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle X-Forwarded-For misconfiguration #1920

Closed
robocoder opened this issue Dec 29, 2010 · 1 comment
Closed

Handle X-Forwarded-For misconfiguration #1920

robocoder opened this issue Dec 29, 2010 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

On the PHP side, we might see:

$_SERVER['HTTP_X_FORWARDED_FOR'] contains "A.B.C.D, E.F.G.H"
while
$_SERVER['REMOTE_ADDR'] also contains "E.F.G.H".

Propose: modify getLastElementFromList() to skip over IP that duplicates REMOTE_ADDR.

@robocoder
Copy link
Contributor Author

(In [3547]) fixes #1920 - also removes deprecated getFirstElementFromList (formerly getFirstIpFromList)

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant