Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove language selection from settings #1930

Closed
tsteur opened this issue Jan 2, 2011 · 4 comments
Closed

Remove language selection from settings #1930

tsteur opened this issue Jan 2, 2011 · 4 comments
Assignees
@tsteur
Labels
enhancement
Milestone
Piwik Mobile 1

Comments

@tsteur
Copy link
Member

tsteur commented Jan 2, 2011

I think we should not make the language selectable. This has several advantages.
The app will be easier for the user because he does not have to worry about it. We can use the Titanium built-in i18n feature which should be faster. We can compile all translations into the app and do not have to query these via HTTP. The app has the correct translation from the first start on.

The i18n feature will automatically use the locale of the phone. We can assume that the user understands that language and it is not necessary to select a different language.

I think the only downside is that we have a larger app file and the user is not able to specify another language (which should not be necessary).

We could create the XML translation files automatically. See here for more details about Titanium i18n feature http://developer.appcelerator.com/guides/en/internationalization.html

Any objections?

We could use i18n as soon as we are compatible to Titanium 1.5
@robocoder
Copy link

I have no objection if this is the convention with other apps. On the other hand, it is a differentiator for Piwik Mobile as it clear that the language can be changed independently of the phone's locale.

Either way, I'm in favor of bundling the translations with the app if it improves startup times. Would it auto-update the translations if the server has a newer version?

@tsteur
Copy link
Member Author

tsteur commented Jan 4, 2011

We currently auto-update the translations via REST api. We cache the fetched translations on the user's device until the user installes a newer version of Piwik Mobile (not server). We would auto-update the translations on each new release even if we bundling the translations with the app.

I don't know any mobile apps where it is possible to change the language. I've absolutely no problem to let the language selectable. I do not think it particularly affects the start time, only the translation function would be a little bit faster.

We could ask the users in the survey (whether they use/want this feature) and decide afterwards.

@mattab
Copy link
Member

mattab commented Jan 4, 2011

I think it makes sense that the language can be changed... who knows maybe people would prefer to use piwik in english for example, rather than their native language (if the translation is not complete for example).

What did you mean by "The app will be easier for the user because he does not have to worry about it." - is it currently complex for the user to pick a language?
Maybe the user default language could be selected by default (if not the case already) ?
Also if you put the language selector at the very end of the settings it won't be confusing. my 2c :)

@tsteur
Copy link
Member Author

tsteur commented Mar 6, 2011

(In [4032]) fixes #1930
from now on we deliver all translations with the app, no more requests necessary
created a simple python script to generate translation files for each language
added Icelandic language
added Arabic, Hebrew, Telugu, Georgian language for iOS
removed Thai language cause it is not supported/correct displayed on android, we still support it on iPhone
removed Amharic language cause it does not work on iPhone and Android
update translation files in preparerelease script

@tsteur tsteur added this to the Piwik Mobile Client milestone Jul 8, 2014
@tsteur tsteur self-assigned this Jul 8, 2014
@tsteur tsteur added this to the Piwik Mobile 1 milestone Jul 25, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
enhancement
Projects
None yet
Milestone
Piwik Mobile 1
Development

No branches or pull requests
3 participants
@tsteur @mattab @robocoder