Opened 3 years ago

Closed 3 years ago

#1940 closed Bug (fixed)

Detect output compression conflict

Reported by: vipsoft Owned by:
Priority: major Milestone: Piwik 1.2
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft)

Check for non-empty settings that likely conflict. Examples:

output_handler = ob_gzhandler

or

auto_append_file = gzip_end.php
auto_prepend_file = gzip_start.php

In these cases, we should set: disable_merged_assets = 1 or add a new setting to disable only the compression aspect (given that serveStaticFile is also used by the piwik.* proxy).

Change History (6)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Description modified (diff)

comment:2 Changed 3 years ago by matt (mattab)

we should only disable compression if possible, rather than disabling merged assets.

comment:3 Changed 3 years ago by matt (mattab)

  • Priority changed from normal to critical

comment:4 Changed 3 years ago by matt (mattab)

Could this be detected by a simple ini_get ?

comment:5 Changed 3 years ago by vipsoft (robocoder)

  • Priority changed from critical to major
  • Summary changed from Installation/Update: output compression conflict to Detect output compression conflict

Yes, if any of the above settings are non-empty, disable compression. We can do this at runtime.

auto_append_file/auto_prepend_file - those are user-defined files (for the example, I used a user's config)

output_handler could be ob_gzhandler, ob_deflatehandler, ob_inflatehandler, ob_iconv_handler, ob_tidyhandler, mb_output_handler, ...

comment:6 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3630]) fixes #1940 - runtime detection for possible conflict

Note: See TracTickets for help on using tickets.