Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect output compression conflict #1940

Closed
robocoder opened this issue Jan 4, 2011 · 4 comments
Closed

Detect output compression conflict #1940

robocoder opened this issue Jan 4, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

Check for non-empty settings that likely conflict. Examples:

output_handler = ob_gzhandler

or

auto_append_file = gzip_end.php
auto_prepend_file = gzip_start.php

In these cases, we should set: disable_merged_assets = 1 or add a new setting to disable only the compression aspect (given that serveStaticFile is also used by the piwik.* proxy).

@mattab
Copy link
Member

mattab commented Jan 4, 2011

we should only disable compression if possible, rather than disabling merged assets.

@mattab
Copy link
Member

mattab commented Jan 5, 2011

Could this be detected by a simple ini_get ?

@robocoder
Copy link
Contributor Author

Yes, if any of the above settings are non-empty, disable compression. We can do this at runtime.

auto_append_file/auto_prepend_file - those are user-defined files (for the example, I used a user's config)

output_handler could be ob_gzhandler, ob_deflatehandler, ob_inflatehandler, ob_iconv_handler, ob_tidyhandler, mb_output_handler, ...

@robocoder
Copy link
Contributor Author

(In [3630]) fixes #1940 - runtime detection for possible conflict

@robocoder robocoder added this to the Piwik 1.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants