Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1.1 seems to copy over all entries below General section #1945

Closed
mattab opened this issue Jan 5, 2011 · 4 comments
Closed

Update 1.1 seems to copy over all entries below General section #1945

mattab opened this issue Jan 5, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
1.1.1

Comments

@mattab
Copy link
Member

mattab commented Jan 5, 2011

The config file after update contains all entries below general copied pasted:


[General]
action_url_category_delimiter = "/"
action_title_category_delimiter = "/"
autocomplete_min_sites = 5
site_selector_max_sites = 10
show_multisites_sparklines = 1
action_default_name = "index"
action_default_name_when_not_defined = "page title not defined"
action_default_url_when_not_defined = "page url not defined"
default_language = "en"
datatable_default_limit = 10
API_datatable_default_limit = 50
default_day = "yesterday"
default_period = "day"
time_before_today_archive_considered_outdated = 10
enable_browser_archiving_triggering = 1
minimum_php_version = "5.1.3"
minimum_mysql_version = 4.1
minimum_pgsql_version = 8.3
minimum_memory_limit = 128
force_ssl_login = 0
login_cookie_name = "piwik_auth"
login_cookie_expire = 1209600
login_cookie_path = ""
login_password_recovery_email_address = "password-recovery@{DOMAIN}"
login_password_recovery_email_name = "Piwik"
enable_framed_logins = 0
language_cookie_name = "piwik_lang"
noreply_email_address = "noreply@{DOMAIN}"
feedback_email_address = "hello@piwik.org"
datatable_archiving_maximum_rows_referers = 1000
datatable_archiving_maximum_rows_subtable_referers = 50
datatable_archiving_maximum_rows_actions = 500
datatable_archiving_maximum_rows_subtable_actions = 100
datatable_archiving_maximum_rows_standard = 500
use_ajax_cdn = 0
jquery_version = "1.4.2"
jqueryui_version = "1.8.4"
swfobject_version = 2.2
reverse_proxy = 0
latest_version_url = "http://piwik.org/latest.zip"
api_service_url = "http://api.piwik.org"

This is critical bug as all users upgrading to 1.1 will have lost the default settings and they will be considered 'customized' even though they are not.
@mattab
Copy link
Member Author

mattab commented Jan 5, 2011

Note: this only happens when a config entry was actually migrated to the config.ini.php

@mattab
Copy link
Member Author

mattab commented Jan 5, 2011

So this is not a critical problem (only fraction of users will see this behavior)...

@mattab
Copy link
Member Author

mattab commented Jan 5, 2011

(In [3626]) Refs #1945

@robocoder
Copy link
Contributor

(In [3643]) refs #1897, refs #1945 - yank this update code ... that's not the desired effect

@mattab mattab added this to the Piwik 1.1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@mattab @robocoder