Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal matching regex - test for regression #1991

Closed
mattab opened this issue Jan 10, 2011 · 7 comments
Closed

Goal matching regex - test for regression #1991

mattab opened this issue Jan 10, 2011 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 10, 2011

A few users have been complaining that Goals are not matched since upgrade to 1.1.

We should add unit tests to test that goal matching works as expected in all supported use cases, if not fix the issue

@mattab
Copy link
Member Author

mattab commented Jan 11, 2011

From Joachim: "the fault is the uncommented / in the regex. With
http://dev.piwik.org/trac/changeset/3344/trunk/core/Tracker/GoalManager.php,
the / are commented by piwik, but it is not checked, if they are already
commented out and also the example in piwik itself is not updated to the new
behaviour."

@mattab
Copy link
Member Author

mattab commented Jan 15, 2011

also, see http://forum.piwik.org/read.php?2,70015

@mattab
Copy link
Member Author

mattab commented Feb 14, 2011

vipsoft, is r3344 doing something in particular or fixing a bug? it seems it broke the regex format. shall I revert?

@mattab
Copy link
Member Author

mattab commented Feb 14, 2011

(In [3901]) Fixes #1991

  • Adding test triggering a goal with regex
  • revert r3344 as the documentation examples are escaped regular expressions

@robocoder
Copy link
Contributor

r3344 is a security best practice because the regex is user input. (If this was a preg_replace, it would have been a potentially serious vulnerability.)

Instead of an unescaped regex failing silently, we should have fixed the docs/examples. Vote to revert 3901.

@robocoder
Copy link
Contributor

Either way, existing goals are affected. Can we add an update script?

Also, there's a UI inconsistency in the input handling of regular expressions (SitesManager/Controller.php).

@robocoder
Copy link
Contributor

(In [3946]) refs #1991 - runtime detect unescaped "/" in patterns, and escape if needed

@mattab mattab added this to the Piwik 1.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Development

No branches or pull requests

2 participants