Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive::build() parameters order is not consistent with API #5440

Closed
mattab opened this issue Jan 3, 2008 · 3 comments
Closed

Archive::build() parameters order is not consistent with API #5440

mattab opened this issue Jan 3, 2008 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 3, 2008

Archive::build() must have the same parameters order as all the API calls that use idSite, Period, Date.

@anonymous-matomo-user
Copy link

Attachment: patch for all API.php plugin files. Warning: manually removed the changes of Controller.php (delivered earlier in ticket #25)
[plugins.patch](http://issues.piwik.org/attachments/5440/plugins.patch)

@anonymous-matomo-user
Copy link

Attachment: patch for Archives.php
[Archive.php.patch](http://issues.piwik.org/attachments/5440/Archive.php.patch)

@mattab
Copy link
Member Author

mattab commented Jan 17, 2008

fixed in 178

mikael thanks
the only thing is that in your patch you’re using an absolute path D:/project/piwik etc. it makes it impossible to apply your patch directly. you should instead have a relative path /modules/Archive.php etc.

@mattab mattab added this to the DVNO milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants