Ticket #20 (closed Bug: fixed)

Opened 1 year ago

Last modified 6 months ago

Archive::build() parameters order is not consistent with API

Reported by: matt Assigned to:
Priority: low Milestone: DVNO
Component: Core Version:
Keywords: Cc:

Description (Last modified by matt)

Archive::build() must have the same parameters order as all the API calls that use idSite, Period, Date.

Attachments

plugins.patch (10.7 kB) - added by mikael on 01/06/08 19:18:57.
patch for all API.php plugin files. Warning: manually removed the changes of Controller.php (delivered earlier in ticket #25)
Archive.php.patch (0.5 kB) - added by mikael on 01/06/08 19:19:46.
patch for Archives.php

Change History

01/03/08 16:51:59 changed by matt

  • description changed.

01/04/08 02:09:29 changed by matt

  • milestone set to DVNO.

01/06/08 19:18:57 changed by mikael

  • attachment plugins.patch added.

patch for all API.php plugin files. Warning: manually removed the changes of Controller.php (delivered earlier in ticket #25)

01/06/08 19:19:46 changed by mikael

  • attachment Archive.php.patch added.

patch for Archives.php

01/17/08 01:40:17 changed by matt

  • status changed from new to closed.
  • resolution set to fixed.

fixed in [178]

mikael thanks the only thing is that in your patch you're using an absolute path D:/project/piwik etc. it makes it impossible to apply your patch directly. you should instead have a relative path /modules/Archive.php etc.