Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the Piwik logo #2008

Closed
mattab opened this issue Jan 12, 2011 · 15 comments
Closed

Allow customizing the Piwik logo #2008

mattab opened this issue Jan 12, 2011 · 15 comments
Assignees
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 12, 2011

We are probably not going to implement theming in the near future (#177), but a cheap and useful alternative would be to just allow 'logo' theming of Piwik. We would still mention 'Piwik' all over the place (too much work to do otherwise), but customizing the logo would be good enough for a start.

See also #1148

Implementation proposal: currently the Piwik logo is a text, but it could be changed to an image. There are a few places where it is displayed:

  • Login screen
  • Product header (reporting UI and Admin UI)
  • Error message (ie. set date=test in the URL)

There could be a new section in the 'General Settings' admin tab, that would allow to upload a .PNG or .JPG logo picture.

The image would then be resized to fit the product header, resized for the login screen and error messages (slightly different sizes).

The admin setting could be:
(x) Use Piwik Logo
( ) Use Custom logo <img src='show current logo'> (when this is clicked, also display "Upload logo" which would overwrite the current logo if any).

The setting could be recorded in the piwik_option table. The logo would be renamed to custom-logo.png so there is no need to record the 'custom logo filename'.

@mattab
Copy link
Member Author

mattab commented Mar 16, 2011

In the code a few places are calling Piwik::getLogoPath() as a helper returning the icon path.

I think we should implement this as soon as possible, as many users need it and edit Piwik manually after each update, resulting in frustration and risk to delay updates.

Proposal

  • New Admin setting under General Settings
  • Customize logo, upload new logo
  • Customize the message to replace the "Piwik is a collaborative project [...]" and link to their own websites.

We can't remove all occurrences of "Piwik" in the software, since in many help pages or help texts, we link to piwik.org. But in these cases it makes sense and it is actually going to help users in most cases.

The goal here is to really allow web agencies, corporations and anyone to easily customize their daily experience with their main logo.

Are there other easy things we can add in that would help?

@mattab
Copy link
Member Author

mattab commented Mar 16, 2011

increasing priority since it has so many requests + is easy to implement.

if anyone wants to contrib a patch please shout

@robocoder
Copy link
Contributor

Since we can't remove all occurrences of "Piwik", perhaps we could add a caption below any third-party logo that gets used, e.g., "Powered by Piwik".

@mattab
Copy link
Member Author

mattab commented Mar 16, 2011

sounds good

@mattab
Copy link
Member Author

mattab commented May 9, 2011

A very cool side effect would be that the Piwik Mobile App also displays the custom logo in the App. We couldn't change the logo on the Android or Apple marketplace, but the in-app logo could show the custom logo.

The logo would be uploaded in a static URL (eg. http://piwik/themes/logo.png) and the Mobile App and other consumers could load & cache it. Maybe we could have an API function to return the logo URL (API.getLogoUrl() ?)

@sgiehl
Copy link
Member

sgiehl commented May 26, 2011

(In [4816]) fixes #2008 added possibility to define custom logo

@mattab
Copy link
Member Author

mattab commented May 27, 2011

(In [4817]) Refs #2008

  • keep uploaded logo ratio after resizing, just force the height (so it works for high logos, or wide logos)

@robocoder
Copy link
Contributor

re: comment:5 I was thinking more along the lines of adding "powered by piwik" as text below the rescaled logo using imagettftext.

Otherwise good work. I would recommend adding a nonce or token auth check to prevent someone from arbitrarily uploading a new logo.

@mattab
Copy link
Member Author

mattab commented May 27, 2011

(In [4820]) Refs #2008

  • When custom logo, don't link the logo on login screen to piwik.org - add credits in footer, very discreet as to maximise the branding experience while still crediting us

@mattab
Copy link
Member Author

mattab commented May 27, 2011

adding powered by piwik on the logo itself would lower the interestingness of customizing logo. Adding credits on login page + many mentions of Piwik across products credit us properly :) Just in Email & PDF maybe we could add a little "Powered by Piwik" in the footer...

@mattab
Copy link
Member Author

mattab commented May 27, 2011

(In [4821]) Kuddos Anthon for spotting this Refs #2008

@robocoder
Copy link
Contributor

The reason I suggested it was because there's a disconnect between a custom logo and what the user will see in the documentation and translations.

@robocoder
Copy link
Contributor

(In [4823]) refs #2008 - check that file_uploads is enabled, temp file exists, allow image/gif, and use PIWIK_DOCUMENT_ROOT where applicable

@julienmoumne
Copy link
Member

Some users are reporting in http://forum.piwik.org/read.php?2,78325 the logo has a fixed http:// url which is not appropriate for accessing Piwik in https. Is it related to this ticket ?

@robocoder
Copy link
Contributor

Reported in #2501.

@mattab mattab added this to the 1.5 - Piwik 1.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants