Opened 3 years ago

Closed 3 years ago

#2046 closed Task (fixed)

Installation: improve "Re-use existing tables"

Reported by: vipsoft Owned by:
Priority: normal Milestone: Piwik 1.2
Component: Core Keywords:
Cc: Sensitive: no

Description

The "condition" to display the "Re-use existing tables" depends on a hard-coded number of expected core tables. This leads to a number of use cases and problems:

  1. user overwrites installation with a newer Piwik version that has added more core tables
    • if the user chooses to re-use, Piwik doesn't create the missing tables
    • if we don't increment this number, the user may be presented with an option that won't work
    • if the site table wasn't previously created (e.g., previously failed installation), user gets
      SQLSTATE[42S22]: Column not found: 1054 Unknown column 'idsite' in 'field list'
      
  2. dev installs Piwik and tries to run the unit tests without first configuring the ![database_tests] section
    • tables defined in ![database] section may be unexpectedly deleted

Change History (2)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Milestone changed from Feature requests to 1.2 Piwik 1.2

On second thought, creating the missing tables isn't really adviseable as there may have been other schema changes (between the current db version and the installed version of the software). Exercise caution when advising people to delete config.ini.php, and re-run the installer to regenerate config.ini.php.

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [3811]) fixes #2046 - increase base table count; fix spurious table deletion

Note: See TracTickets for help on using tickets.