New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visitor Log month view is incomplete #2076
Comments
Attachment: Patch for Piwik 1.1.1 |
dupe of #1873? |
(In [3920]) Fixing typo in date->setDay - thanks monnerat for patch Refs #2076 |
In current trunk, I think it is working, however the "Next" link at the bottom loads an empty page, but there are more visits. was it working in 1.1? |
monnerat, if you could try current trunk and see if the bug if fixed, that would be very useful |
(In [3922]) Fixes #2054, #2076, #1947
|
Piwik 1.2 fixes this issue for browser views, but not for exports ... |
Forget the previous comment: export output seems to always be limited to 20 rows... I think it's another bug :-( |
Refer to #2145 for issues/regressions that require re-investigation. |
As stated in the summary, I only see one day when selecting a month view. The data export function also exports a single day.
From what I can see, this is a timezone problem (I'm east of UTC). It is not clear if the designer's intention were to show an UTC month or a localtime month, but there is some inconsistencies in date handling:
The month start date is taken as UTC first, then copied to some other object and associated to the local timezone, resulting in a local date being the last day of the previous month (for east of UTC). When we establish the list of target date, days are added one by one until the LOCAL TIME month changes: this is immediate.
The correct fix is not obvious: it depends on what is intended (target is UTC or localtime month). I have implemented a fix at the date conversion level, assuming locatime month range is targeted. May be it's not optimal (date handling should be probably changed and/or fully explained), but it allows a full month view.
The text was updated successfully, but these errors were encountered: