Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserAgentParser: misdetect Shiira and Safari #2099

Closed
robocoder opened this issue Feb 20, 2011 · 1 comment
Closed

UserAgentParser: misdetect Shiira and Safari #2099

robocoder opened this issue Feb 20, 2011 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
1.2

Comments

@robocoder
Copy link
Contributor

Shiira 2.2 (a Japanese WebKit based browser) is misdetected as Safari 1.2 (which is actually the webkit version used by Safari 3.2.3)

  • Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/525.28.3 (KHTML, like Gecko) Shiira Safari/125

During my testing, I found Safari would sometimes (spurious, as I have difficulty reproducing) send a truncated User Agent, e.g.,

  • Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/533.19.4 (KHTML, like Gecko)
@robocoder
Copy link
Contributor Author

(In [3950]) fixes #2099 - treat Shiira as Safari since Shiira uses the installed version of Safari's webkit; for truncated UA, use the AppleWebKit version for detection

@robocoder robocoder added this to the Piwik 1.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@robocoder