Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2123 closed Task (fixed)

UI: replace confirm() and alert() with jQuery-UI dialog

Reported by: vipsoft Owned by: SteveG
Priority: low Milestone: 1.5 - Piwik 1.5
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft)

Reference: http://jqueryui.com/demos/dialog/#modal-confirmation

This can be themed/styled and also workaround the Safari/WebKit bug mentioned in #1728.

See also: piwikHelper.windowModal().

Change History (12)

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Owner set to vipsoft

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Description modified (diff)
  • Summary changed from UI: replace confirm() with jQuery-UI dialog to UI: replace confirm() and alert() with jQuery-UI dialog

comment:3 Changed 3 years ago by matt (mattab)

from #1490

The popover showing for Widget delete confirmation (see piwikHelper.windowModal JS) should be reused in other deletion confirmation such as

user deletion,
site deletion,
goal deletion

comment:4 Changed 3 years ago by vipsoft (robocoder)

  • Priority changed from normal to low

comment:5 Changed 3 years ago by SteveG (sgiehl)

@vipsoft: are you still working on that item? If not, I would do so ;)

comment:6 Changed 3 years ago by vipsoft (robocoder)

  • Owner changed from vipsoft to SteveG

@SteveG thanks.

comment:7 Changed 3 years ago by SteveG (sgiehl)

(In [4641]) refs #2123

  • now using jquery.dialog for existing modal confirms
  • replaced js confirm for user deletion with new dialog confirm
  • remove inclusion of jquery blockUI and bgiFrame, as not needed anymore (btw. bgiFrame causes script error in IE 9)
  • fixed some IE 7/8 issues

tested in IE 7/8/9, FF 3.6, Chrome and Safari/Win

comment:8 Changed 3 years ago by matt (mattab)

Last 2 items are:

  • Goals deletion use the dialog
  • Website deletion use the dialog

Kuddos Stefan for reducing our technical debt!

comment:9 Changed 3 years ago by SteveG (sgiehl)

(In [4647]) refs #2123 replaced js confirm with dialog for goal deletion

comment:10 Changed 3 years ago by SteveG (sgiehl)

(In [4648]) refs #2123 replaced last confirm with dialog (site deletion)

comment:11 Changed 3 years ago by SteveG (sgiehl)

  • Resolution set to fixed
  • Status changed from new to closed

(In [4650]) fixes #2123 replaced js alerts with jquery dialogs

comment:12 Changed 3 years ago by SteveG (sgiehl)

(In [4658]) refs #2123 deleted now unused jquery files

Note: See TracTickets for help on using tickets.