Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: replace confirm() and alert() with jQuery-UI dialog #2123

Closed
robocoder opened this issue Mar 3, 2011 · 9 comments
Closed

UI: replace confirm() and alert() with jQuery-UI dialog #2123

robocoder opened this issue Mar 3, 2011 · 9 comments
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@robocoder
Copy link
Contributor

Reference: http://jqueryui.com/demos/dialog/#modal-confirmation

This can be themed/styled and also workaround the Safari/WebKit bug mentioned in #1728.

See also: piwikHelper.windowModal().

@mattab
Copy link
Member

mattab commented Mar 25, 2011

from #1490

The popover showing for Widget delete confirmation (see piwikHelper.windowModal JS) should be reused in other deletion confirmation such as

user deletion,
site deletion,
goal deletion 

@sgiehl
Copy link
Member

sgiehl commented May 1, 2011

@vipsoft: are you still working on that item? If not, I would do so ;)

@robocoder
Copy link
Contributor Author

@SteveG thanks.

@sgiehl
Copy link
Member

sgiehl commented May 5, 2011

(In [4641]) refs #2123

  • now using jquery.dialog for existing modal confirms
  • replaced js confirm for user deletion with new dialog confirm
  • remove inclusion of jquery blockUI and bgiFrame, as not needed anymore (btw. bgiFrame causes script error in IE 9)
  • fixed some IE 7/8 issues
    tested in IE 7/8/9, FF 3.6, Chrome and Safari/Win

@mattab
Copy link
Member

mattab commented May 6, 2011

Last 2 items are:

  • Goals deletion use the dialog
  • Website deletion use the dialog

Kuddos Stefan for reducing our technical debt!

@sgiehl
Copy link
Member

sgiehl commented May 6, 2011

(In [4647]) refs #2123 replaced js confirm with dialog for goal deletion

@sgiehl
Copy link
Member

sgiehl commented May 6, 2011

(In [4648]) refs #2123 replaced last confirm with dialog (site deletion)

@sgiehl
Copy link
Member

sgiehl commented May 6, 2011

(In [4650]) fixes #2123 replaced js alerts with jquery dialogs

@sgiehl
Copy link
Member

sgiehl commented May 7, 2011

(In [4658]) refs #2123 deleted now unused jquery files

@robocoder robocoder added this to the 1.5 - Piwik 1.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants