Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik AutoUpdate (1.1.1 -> 1.2) failing with "Error Opening [absolute/path/to/piwik/latest/latest.zip]" #2125

Closed
peterbo opened this issue Mar 3, 2011 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@peterbo
Copy link
Contributor

peterbo commented Mar 3, 2011

Still very hard to track down (now entries in the server / apache error logs) but it seems like there would be still a file lock on latest.zip when the piwik Updater tries to access it. File is in the given directory, permissions, etc. are correct.

Error was reproducible on my 2 Servers (which have the same config (basepath restriction, vhost, mod_php (5.2.6)). AutoUpdates used to run correctly by now.

Bug related to #1965.

@peterbo
Copy link
Contributor Author

peterbo commented Mar 3, 2011

Tracking down the error more deeply:

Solution:

  • Updated the AutoUpdater to the 1.2 Version
  • Chmodded / Chgrped piwik directory
  • Applied patch (attachment)

@peterbo
Copy link
Contributor Author

peterbo commented Mar 3, 2011

Attachment:
oneClickUpdate-Regression.diff

@robocoder
Copy link
Contributor

Is that your fix?

@robocoder
Copy link
Contributor

Ok, it is a patch. I'll apply and close.

@robocoder
Copy link
Contributor

(In [4003]) fixes #2125 - thanks peterb

@peterbo
Copy link
Contributor Author

peterbo commented Mar 3, 2011

My fix was to replace the Plugin "CoreUpdater", "/core/Unzip.php", "/core/Unzip/PclZip.php" and "/core/Unzip/ZipArchive.php" with the new files from 1.2.

The patch file fixes a warning (and that a possibly existing tmp/piwik directory is correctly removed) in "plugins/CoreUpdater/Controller.php" that uses "file_exists($this->pathRootExtractedPiwik)" while the member "pathRootExtractedPiwik" wasn't set yet.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants