Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2145 closed Bug (fixed)

Live does not always show recent visitors based on timezone

Reported by: vipsoft Owned by: matt
Priority: critical Milestone: Piwik 1.3
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft)

These issues are intertwined. I think we should refactor the Live plugin and add some much needed unit tests.

Timezone:

Export limits:

Change History (10)

comment:1 Changed 3 years ago by saldsl

Confirmed, regression of #1458 again

comment:2 Changed 3 years ago by vipsoft (robocoder)

IIRC this was to fix a problem when the period != 'day'.

comment:3 Changed 3 years ago by vipsoft (robocoder)

  • Description modified (diff)
  • Summary changed from Live - timezone issue (again?) to Live - regressions?

comment:4 Changed 3 years ago by matt (mattab)

See proposed patch in: http://forum.piwik.org/read.php?2,72889,page=1#msg-72911

/piwik/plugins/Live/API.php you will find on about line 240:
- $processedDate = Piwik_Date::factory($date, $currentTimezone);// if not commented, the Period below fails ->setTimezone($currentTimezone);
+ $processedDate = Piwik_Date::factory($date)->setTimezone($currentTimezone);

comment:5 Changed 3 years ago by matt (mattab)

(In [4188]) Refs #572

  • Adding Date Range calendar UI, with "Apply Date Range" button. Possibility to edit the INPUT fields directly rather than clicking in the calendar. Testing that dates are valid (from < to, valid string).
  • Updating calendar to show Loading.. on click (hopefully it makes it less confusing)
  • Fixing few bugs when period=range
  • All reports should load correctly when period=range, including sparklines, graphs & standard tables
  • Refs #2145 renaming parameter to $filter_limit which seems to work OK - it's not even a hack isn't it? :)

TODO:

  • refactor period_select.tpl JS in helper,
  • Metadata compatibility with period=range (at least the World map doesn't work for now)
  • previous TODO still valid

Testing is welcome, please report any bug you find!

comment:7 Changed 3 years ago by Capitalist

This change resolved my issue with incorrectly processed time zones.

comment:8 Changed 3 years ago by matt (mattab)

  • Owner set to matt

comment:9 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [4316]) Fixes #2145 as far as I can see, it should be fixed, but I've been wrong all previous times so testing is very much welcome! thx

Refs #1966 Improving visitor log performance by rewriting the query

comment:10 Changed 3 years ago by matt (mattab)

  • Priority changed from normal to critical
  • Summary changed from Live - regressions? to Live does not always show recent visitors based on timezone
Note: See TracTickets for help on using tickets.