Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live does not always show recent visitors based on timezone #2145

Closed
robocoder opened this issue Mar 4, 2011 · 7 comments
Closed

Live does not always show recent visitors based on timezone #2145

robocoder opened this issue Mar 4, 2011 · 7 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone

Comments

@robocoder
Copy link
Contributor

These issues are intertwined. I think we should refactor the Live plugin and add some much needed unit tests.

Timezone:

Export limits:

@anonymous-matomo-user
Copy link

Confirmed, regression of #1458 again

@robocoder
Copy link
Contributor Author

IIRC this was to fix a problem when the period != 'day'.

@mattab
Copy link
Member

mattab commented Mar 11, 2011

See proposed patch in: http://forum.piwik.org/read.php?2,72889,page=1#msg-72911

/piwik/plugins/Live/API.php you will find on about line 240:
- $processedDate = Piwik_Date::factory($date, $currentTimezone);// if not commented, the Period below fails ->setTimezone($currentTimezone);
+ $processedDate = Piwik_Date::factory($date)->setTimezone($currentTimezone);

@mattab
Copy link
Member

mattab commented Mar 26, 2011

(In [4188]) Refs #572

  • Adding Date Range calendar UI, with "Apply Date Range" button. Possibility to edit the INPUT fields directly rather than clicking in the calendar. Testing that dates are valid (from < to, valid string).
  • Updating calendar to show Loading.. on click (hopefully it makes it less confusing)
  • Fixing few bugs when period=range
  • All reports should load correctly when period=range, including sparklines, graphs & standard tables
  • Refs Live does not always show recent visitors based on timezone #2145 renaming parameter to $filter_limit which seems to work OK - it's not even a hack isn't it? :)
    TODO:
  • refactor period_select.tpl JS in helper,
  • Metadata compatibility with period=range (at least the World map doesn't work for now)
  • previous TODO still valid

Testing is welcome, please report any bug you find!

@mattab
Copy link
Member

mattab commented Mar 26, 2011

see report in http://forum.piwik.org/read.php?2,73916

@anonymous-matomo-user
Copy link

This change resolved my issue with incorrectly processed time zones.

@mattab
Copy link
Member

mattab commented Apr 5, 2011

(In [4316]) Fixes #2145 as far as I can see, it should be fixed, but I've been wrong all previous times so testing is very much welcome! thx

Refs #1966 Improving visitor log performance by rewriting the query

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Development

No branches or pull requests

3 participants