Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate and implement gethostbyaddr() alternatives #2152

Closed
robocoder opened this issue Mar 6, 2011 · 3 comments
Closed

investigate and implement gethostbyaddr() alternatives #2152

robocoder opened this issue Mar 6, 2011 · 3 comments
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.

Comments

@robocoder
Copy link
Contributor

Investigate some of the user contributed alternatives listed in http://php.net/gethostbyaddr to (1) determine the "best" method for a given environment (similar to Piwik_Http) during installation, and (2) use the "winning" method at tracker runtime.

Refactor getHost() out of the Provider plugin.

See #5554.

@mattab
Copy link
Member

mattab commented Mar 26, 2011

the main requirement being performance since this is called for each new visitor, and will soon be called for many visitors... decreasing priority

@robocoder
Copy link
Contributor Author

Agree wrt performance. Clarified ticket description that this is an installation test.

@mattab
Copy link
Member

mattab commented Jan 13, 2014

I think this code is OK as it is?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

2 participants