Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in menu code: double click show orange warning message #2180

Closed
mattab opened this issue Mar 13, 2011 · 2 comments
Closed

Regression in menu code: double click show orange warning message #2180

mattab opened this issue Mar 13, 2011 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.3

Comments

@mattab
Copy link
Member

mattab commented Mar 13, 2011

If you click on dashboard, in the menu, more than once, the orage warning message says "Oops problem during the request, please try again." and fades out 2s later, after the content loaded, (causing the page to jump). I'm pretty sure this is a regression.

Solution: 2 clicks on the same menu /submenu should not trigger more than 1 ajax requests...
@sgiehl
Copy link
Member

sgiehl commented Mar 19, 2011

The problem is, that the first request is aborted, resulting in the error message to be displayed. Maybe hiding the error message on starting the new request could fix the issue.

Adding a

piwikHelper.hideAjaxError('loadingError');

at the beginning of broadcast.loadAjaxContent should help.

@mattab
Copy link
Member Author

mattab commented Mar 20, 2011

(In [4148]) Fixes #2180 Kuddos SteveG!

The message still shows when we click on top right "Settings" while dashboard widgets still loading... but I'm not sure how we could prevent this one (or that it matters so much)

@mattab mattab added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@mattab @sgiehl