Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in GoalTracking - Conversion values not tracked / shown #2195

Closed
peterbo opened this issue Mar 17, 2011 · 9 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@peterbo
Copy link
Contributor

peterbo commented Mar 17, 2011

I have reproduced this in my own piwik instance and in another one. Goal values are not always or not at all recorded, although the goal is successfully triggered with the given value (tracked via firebug).

See Forums: http://forum.piwik.org/read.php?5,73517

@peterbo
Copy link
Contributor Author

peterbo commented Mar 17, 2011

Attachment: This is recorded now
goals-now.JPG

@peterbo
Copy link
Contributor Author

peterbo commented Mar 17, 2011

Attachment: This was recorded in former versions
goals-then.JPG

@mattab
Copy link
Member

mattab commented Mar 18, 2011

This bug might be because of race conditions that the trackGoal requests arrives beforer the trackPageView request. Can you please try, removing the trackPageView call, and see if the revenue is always correctly tracked?

In any case this is bug of course, just trying to confirm

@robocoder
Copy link
Contributor

Peter, can you confirm this is duped/fixed by the patch in #2168?

@robocoder
Copy link
Contributor

ignore comment:2

I suspect the problem is the request is being truncated by the web server or php (eg suhosin).

The new tracking requests are much longer and in the case of trackGoal(), revenue happens to be last parameter in the request (while idgoal is the first).

@robocoder
Copy link
Contributor

(In [4231]) refs #2195 - move revenue parameter closer to start of request (in event request string is truncated)

@peterbo
Copy link
Contributor Author

peterbo commented Mar 29, 2011

Thanks Anthon, I'll apply your patch and in later test stages try to switch to POST the tracking request. Reporting here when tests passed!

@robocoder
Copy link
Contributor

[4231] isn't a fix per se. If your server has limits on the length of the URL requested, query parameters, or client headers, then data may still be truncated. So, you should still take a look at your system config.

  • Apache's LimitRequestLine directive (default 8K)
  • IIS <requestLimits> (default maxUrl 4K, default maxQueryString 2K)
  • lighttpd (total of 64K for client headers)
  • nginx (total of 4K or 8K for the client header)
  • Suhosin's suhosin.get.max_value_length setting (default 512 bytes)

@mattab
Copy link
Member

mattab commented Apr 11, 2011

Assuming the bug comes with a URL exceeding limits, the proper fix to this issue would be to POST the data when there is too much of it, similar to what GA recently released in their JS (probably via Iframe or other mechanisms for cross domain POSTing)

@peterbo peterbo added this to the 1.4 - Piwik 1.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants