Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snort: false positive on piwik.js #2203

Closed
robocoder opened this issue Mar 18, 2011 · 2 comments
Closed

Snort: false positive on piwik.js #2203

robocoder opened this issue Mar 18, 2011 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

Snort generates a false positive on this line in piwik.js:

        escapable = new RegExp('[\\\\\\"\x00-\x1f\x7f-\x9f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]', 'g'),

The Snort rule doesn't check for a closing ] (which was the Mozilla bug that this rule was supposed to detect).

@robocoder
Copy link
Contributor Author

(In [4127]) fixes #2203

@robocoder
Copy link
Contributor Author

(In [4128]) refs #2203 - add unit test for regressions

@robocoder robocoder added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant