Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation: GET request length tests (check long URLs work) #2228

Closed
robocoder opened this issue Mar 25, 2011 · 4 comments
Closed

Installation: GET request length tests (check long URLs work) #2228

robocoder opened this issue Mar 25, 2011 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@robocoder
Copy link
Contributor

Installer (or troubleshooting plugin?) should probe the server to see if there are GET request limits in place.

This is a potential problem since 1.2 and first party which can blow up the request size as it can contain the referer URL (truncated to 1000).

@mattab
Copy link
Member

mattab commented Mar 26, 2011

See related report in forum:

The Piwik request raises a 414 (Request URI too long) error. I don't understand why the string size or server limit could be changed, but I contact my hoster to set a higher limit. The string is also just 1400 characters long.

I think during the install, a GET request is generated and tested to check for mod_security etc. is it correct? maybe we could make this URL longer, eg. 1.5k or so, and test that http code returned is 200? If anything else is reported we could display a customized error message (eg. for 414 or 500 codes) to suggest the pain points (eg. mod_security and/or GET URL limits). thoughts?

@robocoder
Copy link
Contributor Author

Note: the current check should verify the response content. Currently, if the user has a custom 4xx page that returns status code 200, then the we get a false negative.

@mattab
Copy link
Member

mattab commented Apr 28, 2011

rather than doing this, better implement POSTing data if more than 1k or so: #2321

Leaving this open, since it might be useful to check the http response code (4xx) as per comment 3

@mattab
Copy link
Member

mattab commented Jun 1, 2011

we can focus on #2321 which is the correct long term solution

@robocoder robocoder added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants