Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguagesManager.test.php, TranslationsAdmin, and tidy script: refactor saveTranslation #2229

Closed
robocoder opened this issue Mar 25, 2011 · 3 comments
Closed

LanguagesManager.test.php, TranslationsAdmin, and tidy script: refactor saveTranslation #2229

robocoder opened this issue Mar 25, 2011 · 3 comments
Assignees
@robocoder
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
1.3

Comments

@robocoder
Copy link
Contributor

None
@mattab
Copy link
Member

mattab commented Mar 25, 2011

not mandatory to refactor, since we always run the languagesmanager.test.php before release, so having all cleanup code in there is good enough I think

@robocoder
Copy link
Contributor Author

There are differences in the output when each saves the translations to a file. It makes sense to make these uniform through a single writer, to minimize diffs.

@robocoder
Copy link
Contributor Author

(In [4209]) fixes #2229, refs #5591 - TranslationWriter contains refactored saveTranslation code; also added unit tests

@robocoder robocoder added this to the Piwik 1.3 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
@robocoder robocoder mentioned this issue Mar 28, 2011
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@mattab @robocoder