Opened 3 years ago

Closed 3 years ago

#2229 closed Task (fixed)

LanguagesManager.test.php, TranslationsAdmin, and tidy script: refactor saveTranslation

Reported by: vipsoft Owned by: vipsoft
Priority: normal Milestone: Piwik 1.3
Component: Core Keywords:
Cc: Sensitive: no


Change History (3)

comment:1 Changed 3 years ago by matt (mattab)

not mandatory to refactor, since we always run the languagesmanager.test.php before release, so having all cleanup code in there is good enough I think

comment:2 Changed 3 years ago by vipsoft (robocoder)

There are differences in the output when each saves the translations to a file. It makes sense to make these uniform through a single writer, to minimize diffs.

comment:3 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [4209]) fixes #2229, refs #171 - TranslationWriter contains refactored saveTranslation code; also added unit tests

Note: See TracTickets for help on using tickets.