Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2263 closed Bug (fixed)

iframe template in Widgetize plugin without DOCTYPE definition rendered incorrectly in IE

Reported by: andrews Owned by:
Priority: normal Milestone: Piwik 1.3
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

Test setting:

  • piwik hosted on a linux box with apache and php;
  • asp.net pages hosted by IIS contained embedded piwik widgets via Widgetize module and iframes.

The iframe template file for Widgetize module (plugins/Widgetize/templates/iframe.tpl) is missing DOCTYPE definition and causes incorrect rendering in IE 8.0 and other IE versions. The screenshots are attached. The Firefox 3.16 and others was able to render iframes properly even without DOCTYPE.

The observed issues were:

  • graph icons half shown (probably because of incorrect height calculation);
  • the width of the graph itself inside of the iframe was too big, thus the right border of the graph (NOT the iframe border) was not shown and only adding a scrollbar and scrolling right could show the border.

I tried many test scenarios with <iframe width="" height="" ...>, placing the iframe inside of a HTML table or div and changing the parent's width. Nothing helped until the DOCTYPE string was added to the template:

<!DOCTYPE HTML PUBLIC "-W3CDTD HTML 4.01EN" "http://www.w3.org/TR/html4/strict.dtd">

Then everything was rendered properly.

Please, consider adding this or any other suitable doctype to the iframe template in the next Piwik release.

Attachments (2)

widgetize_iframe_without_doctype.jpg (37.8 KB) - added by andrews 3 years ago.
Incorrect rendering of Widgetize iframes without DOCTYPE
widgetize_iframe_with_doctype.jpg (37.5 KB) - added by andrews 3 years ago.
Corrent rendering of Widgetize iframes with DOCTYPE

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by andrews

Incorrect rendering of Widgetize iframes without DOCTYPE

Changed 3 years ago by andrews

Corrent rendering of Widgetize iframes with DOCTYPE

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Keywords widgetize iframe doctype Internet Explorer incorrect rendering icons width removed
  • Milestone set to 1.3 - Piwik 1.3

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [4307]) fixes #2263 - fix inconsistencies in template headers

Note: See TracTickets for help on using tickets.