Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframe template in Widgetize plugin without DOCTYPE definition rendered incorrectly in IE #2263

Closed
anonymous-matomo-user opened this issue Apr 4, 2011 · 4 comments
Closed

iframe template in Widgetize plugin without DOCTYPE definition rendered incorrectly in IE #2263

anonymous-matomo-user opened this issue Apr 4, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.3

Comments

@anonymous-matomo-user
Copy link

Test setting:

  • piwik hosted on a linux box with apache and php;
  • asp.net pages hosted by IIS contained embedded piwik widgets via Widgetize module and iframes.

The iframe template file for Widgetize module (plugins/Widgetize/templates/iframe.tpl) is missing DOCTYPE definition and causes incorrect rendering in IE 8.0 and other IE versions. The screenshots are attached. The Firefox 3.16 and others was able to render iframes properly even without DOCTYPE.

The observed issues were:

  • graph icons half shown (probably because of incorrect height calculation);
  • the width of the graph itself inside of the iframe was too big, thus the right border of the graph (NOT the iframe border) was not shown and only adding a scrollbar and scrolling right could show the border.

I tried many test scenarios with <iframe width="" height="" ...>, placing the iframe inside of a HTML table or div and changing the parent's width. Nothing helped until the DOCTYPE string was added to the template:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

Then everything was rendered properly.

Please, consider adding this or any other suitable doctype to the iframe template in the next Piwik release.
@anonymous-matomo-user
Copy link
Author

Attachment: Incorrect rendering of Widgetize iframes without DOCTYPE
widgetize_iframe_without_doctype.jpg

@anonymous-matomo-user
Copy link
Author

Attachment: Corrent rendering of Widgetize iframes with DOCTYPE
widgetize_iframe_with_doctype.jpg

@robocoder
Copy link
Contributor

(In [4307]) fixes #2263 - fix inconsistencies in template headers

@robocoder
Copy link
Contributor

(In [4308]) refs #2263

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@robocoder @anonymous-matomo-user