Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google advanced search not detected #2283

Closed
sgiehl opened this issue Apr 8, 2011 · 2 comments
Closed

Google advanced search not detected #2283

sgiehl opened this issue Apr 8, 2011 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Apr 8, 2011

In one special case Google's advanced search is not detected correctly.

In [https://github.com/piwik/piwik/blob/master/core/Common.php#L1378] Google's advanced search params are handled. In case that the as_q parameter is the first argument of the query string that doesn't work. I guess an additional check for ?as_q should fix that issue.

@robocoder
Copy link
Contributor

(In [4371]) fixes #2283

@robocoder
Copy link
Contributor

(In [4481]) refs #2319, refs #2283 - less strict on the parameter match for Google Advanced search

- www.google.it/search?as_q=xxxxxx
- www.google.com.br/search?as_epq=xxxxxx
- www.google.de/search?as_q=xxxxxx
- www.google.fr/search?as_epq=xxxxxx

@sgiehl sgiehl added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants