Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bing subdomains to search engines #2284

Closed
sgiehl opened this issue Apr 8, 2011 · 3 comments
Closed

add bing subdomains to search engines #2284

sgiehl opened this issue Apr 8, 2011 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Apr 8, 2011

Bing has subdomains their search is also running on:

We should add {}.bing.com in both cases to search engine definition: [https://github.com/piwik/piwik/blob/master/core/DataFiles/SearchEngines.php#L204]

@robocoder
Copy link
Contributor

(In [4372]) fixes #2284

@sgiehl
Copy link
Member Author

sgiehl commented Apr 8, 2011

That change only handles the "normal" search, am i right? Subdomains for the image search might be counted as bing instead of bing images.

@robocoder
Copy link
Contributor

(In [4375]) refs #2284 - quite right; though I could have sworn I saw it redirect to www.bing.com/images earlier

@sgiehl sgiehl added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants