Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunk JS error in IE8 (maybe other IE as well) #2295

Closed
mattab opened this issue Apr 11, 2011 · 16 comments
Closed

trunk JS error in IE8 (maybe other IE as well) #2295

mattab opened this issue Apr 11, 2011 · 16 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 11, 2011

as much as I hate IE we must fix this!

Calendar doesn't show the days, simply the first row of the calendar... if anyone is keen to debug this please do :)

@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2011

(In [4401]) refs #2295 IE <9 can't handle new Date('yy-mm-dd') use datepickers
parsedate instead. layout is still broken in ie <9

@mattab
Copy link
Member Author

mattab commented Apr 11, 2011

Thanks Steve good stuff! It is working in IE8 now as well, why do you say it doesn't work in IE<9 ?

@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2011

Couldn't test it in IE 8 right now. In IE 7 the layout is broken

@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2011

Attachment:
ie7.png

@mattab
Copy link
Member Author

mattab commented Apr 11, 2011

selecting date ranges work in current month, but if I change months I get:


Message: 'G.j().images' is null or not an object
Line: 51
Char: 352
Code: 0
URI: http://localhost/trunk/index.php?module=Proxy&action=getPieHtc


@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2011

That sounds like a problem with the pie. Will take a look at this later.

@mattab
Copy link
Member Author

mattab commented Apr 11, 2011

Also on the Widgets page I see a "Expected ; at the end of" with a garbage line (WHY does this debugger does NOT tell the right line, even with developer tools grrrr)

@mattab
Copy link
Member Author

mattab commented Apr 11, 2011

After updating to trunk and the new version of CSS PIE, the problem is still there so it is a different one..

The JS bug appears:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Mon, 11 Apr 2011 21:41:37 UTC

Message: Expected ';'
Line: 78421269
Char: 22
Code: 0
URI: http://localhost/trunk/index.php?module=CoreHome&action=index&idSite=1&period=range&date=last30

The debugger won't give the backtrace or give the proper line number, I'm not sure how to go to debug this?

@mattab
Copy link
Member Author

mattab commented Apr 11, 2011

Note that now the date range works in IE8, but there is this JS error (not sure if it breaks anything?)

@sgiehl
Copy link
Member

sgiehl commented Apr 11, 2011

(In [4412]) refs #2295 fixes layout problem in IE7

@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2011

(In [4414]) refs #2295 fixes manual input of a date in ie <9

@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2011

matt, I can't reproduce your error in IE8 or IE7. Did that error occur with merged assets enabled or disabled?

@mattab
Copy link
Member Author

mattab commented Apr 12, 2011

I get the error on IE 8.0.6001 (I think latest version?) with both merged assets enabled or disabled, on the Dashboard page and on the Widgets page.

I dont get it on API/All Websites/Email reports pages so probably a problem in the menu or datatable code.

@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2011

(In [4422]) refs #2295 no need to load ieonly.css in ie9, cause pie not needed here

@sgiehl
Copy link
Member

sgiehl commented Apr 12, 2011

Well, tried to reproduce it on another system now, but its working here aswell. No JS-Errors ouccred while switching dates.

While testing I sometimes had the issue that the pie seemed to break the complete layout in IE8. Do you have that problem, too?

I think we should consider removing the pie again in the future, as now IE9 supports rounded corners.

Btw is the latest tag already available on the demo? Maybe I could reproduce the error there.

@mattab
Copy link
Member Author

mattab commented Apr 13, 2011

Thanks Steve I pushed 1.3rc1 to the demo and it is working fine, excellent!

@mattab mattab added this to the Piwik 1.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Development

No branches or pull requests

2 participants