Opened 3 years ago

Closed 3 years ago

#2299 closed New feature (fixed)

Tracker API setForceVisitDateTime should accept UNIX Timestamp as well as date time

Reported by: matt Owned by:
Priority: major Milestone: 1.6 Piwik 1.6
Component: Core Keywords:
Cc: Sensitive: no

Description

per title

Change History (6)

comment:1 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [4411]) Fixes #2299, refs #2172 (in case it is easier for you, now the function will accept a timestamp as well)

comment:2 Changed 3 years ago by JulienM (JulienMoumne)

  • Resolution fixed deleted
  • Status changed from closed to reopened

On my box, PHP 5.3.5, Windows 7x64, http://dev.piwik.org/trac/browser/tags/1.5.2b4/core/Tracker/Visit.php#L66 returns true when an unix timestamp is provided.

is_int(123) = true
is_int("123") = false

The timestamp is therefore fed to strtotime which returns false.

The tracking output confirms the problem :

Current datetime: 1970-01-01 00:00:00

And the tracking process fails with the following error :

Error query: SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'visit_total_time' at row 1 In query: UPDATE piwik_log_visit SET visit_total_actions = visit_total_actions + 1, visit_exit_idaction_url = ?, visit_exit_idaction_name = ?, visit_last_action_time = ?, visit_total_time = ?, visit_goal_buyer = ? WHERE idsite = ? AND idvisit = ? Parameters: array ( 0 => 5, 1 => 1, 2 => '1970-01-01 00:00:00', 3 => -1302306504, 4 => '0', 5 => 1, 6 => '20', )

comment:3 Changed 3 years ago by matt (mattab)

  • Priority changed from normal to major

comment:4 Changed 3 years ago by matt (mattab)

Also http://forum.piwik.org/read.php?2,80273


$t->setForceVisitDateTime(date("Y-m-d H:i:s", 1296546002))

This is being rendered as:

cdt=2011-02-01+07%3A40%3A02

rather than

cdt=2011-02-01%2007%3A40%3A02

I believe the setForceVisitDateTime() function is adding the +. 
  • must clarify API and provide better examples maybe?

comment:5 Changed 3 years ago by matt (mattab)

  • Milestone changed from Piwik 1.3 to 1.6 Piwik 1.6

comment:6 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5254]) Fixes #2299

Note: See TracTickets for help on using tickets.