Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling piwikTracker.getVisitorId() early causes random ID to return, not persisted #2315

Closed
mattab opened this issue Apr 15, 2011 · 3 comments
Closed

calling piwikTracker.getVisitorId() early causes random ID to return, not persisted #2315

mattab opened this issue Apr 15, 2011 · 3 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.3

Comments

@mattab
Copy link
Member

mattab commented Apr 15, 2011

when calling JS API piwikTracker.getVisitorId() early (before the trackPageView() call) the returned ID will be a random one, not actually used by Piwik later. Instead, loadVisitorCookie should set the cookie when it's not already set.
@mattab
Copy link
Member Author

mattab commented Apr 15, 2011

(In [4462]) Fixes #2315 and updating tests (starting to love these JS tests ;)

@robocoder
Copy link
Contributor

The code should only persist uuid (in a variable).

The current code fails for a new visitor when you call getVisitorId() and then trackPageView() because the saved cookie will incorrectly be treated as a return visitor.

@robocoder
Copy link
Contributor

(In [4475]) fixes #2315

@mattab mattab added this to the Piwik 1.3 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@mattab @robocoder