New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunk: test_P2N_invalidInput & test_getHostByAddr in IP.test.php fail #2359
Comments
Is that on Windows? |
I should have mentioned it, it's on Windows 7 x64 |
On Windows XP 32bits, I get many errors:|
Good that we have unit tests to find these out ;) |
Matt: is that php 5.2.6? (just making sure because pre-5.3 uses the compat functions). |
Yes I am running 5.2.6 - if it's too difficult / not possible to have ipv6 on pre 5.3, I think it's reasonnable, but we need to clarify it and fail gracefully (not sure what it would mean?) |
When I generate a new visit on windows 5.2.6, with debug on, I see in the piwik.php output:
'location_ip' => '�' . "\0" . '' . "\0" . '�', ``` quite interesting ;) |
thanks. i will fix this today. |
(In [4564]) fixes #2359 - note: on Windows with php 5.1.x/5.2.x, gethostbyaddr() doesn't work with ipv6 addresses |
Thanks for fixing tests. There is still an issue, that on pre 5.3, ipv4 is not supported anymore. Is it possible that we leave the ipv4 address as is somehow? for example, I try:
And, this shows in output: New Visit (IP = 0.0.0.0) Is it possible, that ipv4 IPs are compatible with new code, so as to not introduce regression? |
(In [4565]) fixes #2359 - looks like this debug statement was added while I was working in my own branch |
re: comment:10 -- I did a grep and didn't find any other lingering long2ip/ip2long calls that shouldn't be there. |
(In [4566]) refs #2359 - catch more edge cases as errors |
(In [4567]) refs #2359 - relax some of the rules for compatibility with native function |
(In [4570]) refs #2359 - clean up php_compat_inet_pton |
I have two minor failing tests in test_getHostByAddr().
returns the name of my machine with capital letters :
instead of what's displayed if I press Windows + Pause :
However,
correctly returns
failing both asserts. |
(In [4621]) refs #2359 - thanks Julien |
With my box (PHP 5.3.5, HTTPD 2.2), in test_P2N_invalidInput
returns
instead of expected
In test_getHostByAddr, both
return the name of my computer: ju-PC
The text was updated successfully, but these errors were encountered: