Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFiles: add FIPS 10-4 Subcountry #2379

Closed
robocoder opened this issue Apr 30, 2011 · 10 comments
Closed

DataFiles: add FIPS 10-4 Subcountry #2379

robocoder opened this issue Apr 30, 2011 · 10 comments
Assignees
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@robocoder
Copy link
Contributor

Using the data from www.maxmind.com/app/fips10_4, build a lookup table, i.e., from subcountry/region name to FIPS 10-4 code (and possibly the converse, see #1652).

This will used by #1823 to convert region names (as supplied by geolocation providers) to the more compact FIPS 10-4 code (when storing in the log_visit table).

@robocoder
Copy link
Contributor Author

Given that FIPS 10-4 was withdrawn from the standards track, how much overlap is there with ISO 3166-2?

@mattab
Copy link
Member

mattab commented Oct 23, 2011

Anthon, sounds good -

@robocoder
Copy link
Contributor Author

Greg: do you have any additional equirements that I can accomodate here? (Relating to 1652).

this will be a mapping of fips10-4 to a subcountry (aka region) name

  • do we need these names to be translateable?

In the future, there will be some methods (probably specific to a geolocation provider) for reverse lookup (ie store the more compact fips10-4 code).

  • there's as yet, no iso 3166 standard for subcountries

@robocoder
Copy link
Contributor Author

Sorry, last bullet point is incorrect

  • there isn't a one-to-one mapping between iso 3166-2 and fips10-4

(The iso 3166-2 standard isn't stable; it changes to reflect geopolitical changes.)

@mattab
Copy link
Member

mattab commented Jan 26, 2012

do we need these names to be translateable? 

No, only countries are translatable in Piwik (we should not have to add new translations for this feature)

Is there any issue that you can think of for this ticket, or all is clear?

@robocoder
Copy link
Contributor Author

Since we don't know what version of the GeoIP database a user may have installed, we have to include retired codes.

However, I noticed the following:

  • a region may get a new code but keep the same name (e.g., JO 10 "Al Mafraq" becomes JO 15 "Al Mafraq")
  • a region may get a new name but keep the same code (e.g., YE 06 "Al Ghaydah" becomes YE 06 "Lahij")

This will inevitably lead to questions (or bug reports) like "Al Mafraq appears twice in the table". So follow-up tasks to this one:

  • add a FAQ entry
  • monitor changes to MaxMind's fips_include list (e.g., a daily cron or Jenkins job) so we have timely updates

@mattab
Copy link
Member

mattab commented Jan 30, 2012

Maybe there won't be "double rows" since Piwik should, for a given month, deduplicate same labels ? It would only have the issue the day and month during the upgrade between old new format?

In any case a FAQ would be more than enough, probably it will not happen much.

Thanks for your status update, hopefully the data sets we are going to package to be used by 250,000 server is of good quality and fast to access? :)

@mattab
Copy link
Member

mattab commented Dec 14, 2012

Dealt with in: #1652

@mattab
Copy link
Member

mattab commented Dec 16, 2012

Milestone 1.8.x Piwik 1.8.x deleted

@mattab
Copy link
Member

mattab commented Dec 27, 2012

We need YOUR help! We are running a crowd funding campaign to raise funds to implement the detailed Visitors Maps of Countries, Regions and Cities (for all countries)!

These maps will be beautiful, usable, and built using open standards SVG+JS. They will show detailed visitor count, conversion rates, by Country but also (New!) by city and region.

Pledge now at: http://crowdfunding.piwik.org/analytics-maps-world-country-city-region/

Piwik needs you!

@robocoder robocoder added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants