Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor Log to show one day too early in some cases #2387

Closed
mattab opened this issue May 1, 2011 · 7 comments
Closed

Visitor Log to show one day too early in some cases #2387

mattab opened this issue May 1, 2011 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented May 1, 2011

See example in forum

It is a small regression following recent fixes.

@sgiehl
Copy link
Member

sgiehl commented May 4, 2011

Guess the problem is here:

https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L308

If period is day it will always show the day before!

@peterbo
Copy link
Contributor

peterbo commented May 4, 2011

PLease also refer to [http://forum.piwik.org/read.php?5,76195] - I already had a talk with Matt about this statement. It seems like deleting the "->subDay(1)" call would rise another issue.

@mattab
Copy link
Member Author

mattab commented May 16, 2011

I have commmitted a patch for this issue, see the few lines following: https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L372

I haven't tested much, in particular with timezones like GMT-8 and GMT+8 but these few lines should help

@mattab
Copy link
Member Author

mattab commented May 17, 2011

(In [4710]) Fixes #2387 - test is most welcome!

@anonymous-matomo-user
Copy link

Thanks for the fix, but I'd like to know if it is ok just overwrite the stock file(API.php) with the trunk.

In stock 1.4, the "->subday(1)" makes errors on day/week/month/year selection on specific dates in Visitor Log page, please check my test result on (note: user-defined range does not have errors)
http://forum.piwik.org/read.php?2,76196,page=1#msg-77084

@mattab
Copy link
Member Author

mattab commented May 20, 2011

It's not going to work to reuse the API.php file like this, but you can just try to change the IF block that starts at line: https://github.com/piwik/piwik/blob/master/plugins/Live/API.php?rev=4710#L375 then it should work with 1.4

Your tests are very appreciated.. I am not 100% sure that all issues are fixed!

@anonymous-matomo-user
Copy link

so far so good it seems to have fixed my issues will report back if I find anything.

@mattab mattab added this to the 1.5 - Piwik 1.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants