Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF reports - long lines overflow into adjacent cell, or truncated [patch] #2392

Closed
anonymous-matomo-user opened this issue May 3, 2011 · 8 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

Small display error in PDF reports. If text is too long for one cell it will sometimes (if cell has no background colour?) flow in adjacent cell and make content unreadable. Happened for Visitor overview and Returning Visitors report. See attached screenshots.

Also mentioned in http://forum.piwik.org/read.php?5,76084

@anonymous-matomo-user
Copy link
Author

@anonymous-matomo-user
Copy link
Author

@robocoder
Copy link
Contributor

I think this is the flip side of #1601.

@mattab
Copy link
Member

mattab commented May 25, 2011

I don't think it's easy to do, or maybe I just don't know about it... ? Decreasing priority but of course if a patch is submitted it would be great :)

@mattab
Copy link
Member

mattab commented May 25, 2011

Maybe worth trying to replace Cell() by MultiCell() in the generation code (see http://stackoverflow.com/questions/2938953/word-wrap-in-tcpdf )

@anonymous-matomo-user
Copy link
Author

Setting a a white background on the even rows, like the green on the uneven, will do the trick. This will hide the overflowing text.
But it might be a better idea to make the cells wider, there's plenty of room left.

@anonymous-matomo-user
Copy link
Author

Quick and dirty fix is the following configuration:

/core/ReportRenderer/Pdf.php

//line 29
    private $bottomMargin = 15;
    private $reportWidthPortrait = 195;
    private $reportWidthLandscape = 270;
    private $minWidthLabelCell = 100;
    private $maxColumnCountPortraitOrientation = 6;
    private $truncateAfter = 55;

Line 326 // Computes available column width

        // Computes available column width
        $this->totalWidth = $totalWidth;
//      $this->labelCellWidth = max(round(($this->totalWidth / $columnsCount) * 2), $this->minWidthLabelCell);
//      Changed by Jens Verneuer
        $this->labelCellWidth = max(round(($this->totalWidth / $columnsCount) ), $this->minWidthLabelCell);
        if ($columnsCount == 2) {
//      Changed by Jens Verneuer            
//      $this->labelCellWidth = $this->totalWidth / 2;
        }
        $this->cellWidth = round(($this->totalWidth - $this->labelCellWidth) / ($columnsCount - 1));
        $this->totalWidth = $this->labelCellWidth + ($columnsCount - 1) * $this->cellWidth;

Additionaly I decreased the Font Size a bit, because some of our Website Names are to long for the first Paper of the Report
Line 27/28:

    private $reportSimpleFontSize = 9;
    private $reportHeaderFontSize = 16;

works fine 4 us

@mattab
Copy link
Member

mattab commented Sep 27, 2011

(In [5234]) Thanks mattenschwinger Fixes #2392

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants