Update jquery + jquery plugins to the last versions #5663
Comments
|
jquery is really sure to make an automatic update without tests from piwik time ? And it’s a little useless, because the new features (without some improvements) aren’t used yet (piwik can’t be based on a future-release of jquery) |
|
i tested (http://dev.piwik.org/trac/wiki/HowToTestUI) with firefox and used jquery-1.2.6-min, following results:
maybe the weren’t before…
Its not klickable but if i click there is a new box wich says “Loading widget please weight” and im still waiting :) last thing i saw is that the menus of language- and site selection are visible and without arrows… |
|
next test was with updated swfobject, no problems. |
|
sorry, the new swfobject hides all graphs. |
|
what other jquery plugins are to be tested? |
|
jQuery (current: 1.2.2; latest: 1.2.6) SWFObject (current: 1.5; latest 2.1) fdd2div (current: 1.0; latest: 1.0.1) Don’t know if it fixes ticket #451. truncate (version ???) Could look into using http://www.reindel.com/truncate/ (v2.3) |
|
re: pebosi’s observations re: the latest swfobject; the API changed, i.e., the object interface is gone matt added in email: “Also we have patched some libs (UI sortable, fdd2div, superfish) so let’s not update these ones.” |
|
Attachment: swfobject 2.1 update: replace 3 files, add libs/swfobject/expressInstall.swf (though not currently used), and remove libs/swfobject/README.txt |
|
Attachment: Sync with sparkline cvs repository (minor bug fixes & dual license change) |
|
fdd2div (original and modified) are broken by jquery 1.2.6 |
|
Notes: ui.mouse was moved into the jquery ui.core in 1.5.3; similarly, calendar was adopted as ui.datepicker |
|
Attachment: Fix for jquery 1.2.6. |
|
Attachment: Update to jquery-tooltip from 1.1 to 1.3; minor changes as a result of $.fn.Toolkit() being deprecated & removed in favor of $.fn.toolkit() |
|
TODO: “Loading data” for swfobject isn’t centred (appears in the top left corner) in the widget. |
|
Suggest update of swfobject should coincide with resolution of ticket #322 (update to Open Flash Chart v2). |
|
Attachment: Forward port changes to jquery-superfish 1.4.8 and use superfish arrows |
|
Updated blockUI (from 1.33 to 2.11), dimensions (from 1.1.2 to 1.2), and scrollTo (from 1.3 to 1.4) unchanged, with no apparent ill effect. I left ui.mouse, ui.sortable, and calendar alone (as there are big differences going to jquery.ui 1.5.3). I’ll put together a patch and/or zip that rolls up all the above. If there’s no objection, I’ll probably use the YUI compressor to minify the locally modified versions of fdd2div and superfish. |
|
Here’s the roll-up of changes: Summary of changes: Files added: Files removed: No change to: ui.mouse, ui.sortable, and calendar (Attachment to follow.) |
|
Attachment: Replaces patch for core/ViewDataTable/GenerateGraphHTML.php. |
|
vipsoft, thank for the patches. Can you please confirm, that after applying all your patches, you have tested your updated Piwik following the procedure described in http://dev.piwik.org/trac/wiki/HowToTestUI (I’ve just slightly updated it); I would recommend testing with Firefox, Internet explorer, and Safari (or Chrome): the three major web engines. This is really important to make sure there are no regression in the UI. |
|
I’ll let you know when I’m done testing. |
|
Matt: I’ve had to halt testing as there’s a major regression where Dashboard changes (e.g., adding/removing/re-adding widgets) manipulates the DOM and leaves it in a bad state. I’ll continue to investigate… To anyone else monitoring this ticket: there were some other regressions which I’ve since fixed but are not reflected in the previously attached files. |
|
Ok, patches are on their way. I’ll also include a fix to ticket #506. |
|
Attachment: Roll-up – contains diffs and new files |
|
tried to apply the diff to my piwik installation, but patching of some files failed: ############# patching file plugins/Dashboard/templates/Dashboard.js ############# and these days jquery 1.3.1 is released. |
|
``` |
|
pebosi: did you “svn up” first? the diffs are against the repository (as of 882), and there was a widespread change to fix newlines per ticket #452. |
|
vipsoft, is it safe now to patch Piwik? are you done with the testing? i’d like to commit asap :) thanks. |
|
Do you want to wait for pebosi’s feedback? I finished testing a couple of weeks ago. I already noted the issue of the swfobject “Loading data” message occasionally not being centered; I firmly expect this will self-correct itself when we move to OFC2 in ticket #322. |
|
dont need to wait, first time i tried to patch 0.2.28, patching svn version works ;) |
|
Matt: Having heard no complaints, it looks like this patch can be committed. Thanks. |
|
guys, this is a great work! thank you for your help testing pebosi, and kudos to vipsoft for your patience and testing. in 886 |
|
In [1548], refs #5663 - remove obsolete jquery.dimensions.js; now part of jquery.js 1.2.6 |
Task
Update javascript librairies to their latest/fastest releases: jquery, jquery plugins, swfobject.
jquery
http://feeds.feedburner.com/~r/ajaxian/~3/303858275/jquery-release-126-performance-improvements-and-dimensions-plugin-added-to-core
We are using fast changing libraries in Piwik. We should try to upgrade the libraries as often as possible, every few months, so we stay in line with the APIs and latest features.
A new release of jQuery is out 1.2.6. The headlines on improvements:
\* Event handling: 103%
\* CSS selectors: 13%
\* .offset: 21%
\* .css: 25%
Lots of other fixes, but the most important, IMHO, is the inclusion of Brandon Aarons Dimensions plugin cross browser support for find element dimensions, offsets and positioning in the jQuery core. Check out the release notes here.
As we are using dimensions and jquery, we definitely should upgrade to this new version.
testing
- http://dev.piwik.org/trac/wiki/HowToTestUI Go through the UI checklist after the upgrade to make sure it hasn’t broken the ui on ie/ff at least
The text was updated successfully, but these errors were encountered: