Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All API functions (including Actions.* and Goals.*) should support all segments #2434

Closed
anonymous-matomo-user opened this issue May 17, 2011 · 2 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

Currently the Goals plugin & Actions plugin does not issue an error when given an unsupported Segment.

@mattab
Copy link
Member

mattab commented May 17, 2011

The list of SQL segments supported by the Goals API are:

'idvisitor',
'referer_type',
'referer_name',
'referer_keyword',
'visitor_returning',
'visitor_days_since_first',
'visitor_days_since_order',
'visitor_count_visits',
'visit_goal_buyer',
'location_country',
'location_continent',
'revenue',
'custom_var_k1',
'custom_var_v1',
'custom_var_k2',
'custom_var_v2',
'custom_var_k3',
'custom_var_v3',
'custom_var_k4',
'custom_var_v4',
'custom_var_k5',
'custom_var_v5',

We should either:

  • Make all dimensions work for Goals plugin
  • For all unsupported dimensions, return an error message "The segment 'actions' is not supported for this API call"
    • Note that, in some cases, the "per goal" metrics are not available, but the general metrics are available. For example, segment=actions>1 will return "Top keywords" but will not return "Goal X conversions /Goal Y conversion rate / Goal Z revenue" for each keyword. In this case, we shall not return an error message, but just return the common metrics not enriched with the goal details.

I vote for the solution to make all segments work for all API functions.

@mattab
Copy link
Member

mattab commented May 18, 2011

(In [4717]) Fixes #2434 Now Actions.get* and Goals.get* (which were the two API not supporting all segments) have full support of all segments + adding tests

Refs #2432

  • Processing Custom vars per page: they are merged in the existing Custom Variables output (rather than create a separate one)
  • So there is no need for a new Report in the UI, Custom variables of scope "page" are displayed in the "Visitors > Custom Variables" report
  • Displaying Custom vars per page in the Live API output

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants