Opened 3 years ago

Closed 2 years ago

Last modified 23 months ago

#2461 closed New feature (fixed)

UI: Selector to choose how many rows to display, in each report footer

Reported by: matt Owned by: SteveG
Priority: major Milestone: 1.7.x - Piwik 1.7.1
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description (last modified by matt)

Users have asked that, on the Report page (Top websites/referrer/search engine), we could show more than the default 10 rows, since users are explicitely asking for this report, rather than just looking at it from the dashboard. Maybe we could show 20 by default for the keywords/websites/campaigns.

Note: we would show more than 10 when the report is not loaded "as a widget".

Change History (17)

comment:1 Changed 3 years ago by matt (mattab)

  • Description modified (diff)

comment:2 Changed 2 years ago by SteveG (sgiehl)

  • Owner set to SteveG

comment:3 Changed 2 years ago by matt (mattab)

To allow to display more rows for any report in Piwik, maybe there could be a small SELECT element, in the datatable footer, aligned on the right, next to the current footer icons that are left aligned?

Such selector could have the options to show [10, 25, 50, 100, 250, all] rows.

It would be cool if the user preference was saved, but it shouldn't be done as part of this ticket but see: #1915

comment:4 Changed 2 years ago by SteveG (sgiehl)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5891]) refs #1915, fixes #2461 added new limitation select to all datatables. users can now select how many rows to display. limit changes to widgets on dashboard will automaticly be stored within layout and restored on reload. changed default limits to referer datatables to 25

comment:5 Changed 2 years ago by matt (mattab)

(In [5893]) Refs #2461 - resetting offset when switching number of rows to display.

This is to work around problem: Display 5 rows, click Next, click next, then click display 50 rows, it should show from the start

comment:6 Changed 2 years ago by matt (mattab)

(In [5894]) Refs #2461

  • Small CSS adjustements (less wide, border lighter grey (reusing grey from menu)
  • Only display the selector when the table has the pagination and offset details displayed. For example for Visitors > Engagement reports, because we know the number of rows is always the same (fixed reports), then we keep things simple and do not allow to paginate and/or change number of rows to display
  • Adding "title" to explain what the controller does on hover (all browsers display it which is nice)

comment:7 Changed 2 years ago by matt (mattab)

(In [5896]) Refs #2461

  • Fix Visitor Log bug that when changing rows limit, it would paginate through because the maxIdVisit is passed automatically. Using a hack to fix a hack.
  • Put the arrow in lighter grey as to attract attention less

comment:8 Changed 2 years ago by matt (mattab)

  • Milestone changed from 1.8 Piwik 1.8 to 1.7.x - Piwik 1.7.1
  • Summary changed from Display more than 10 rows on details page (referrer) to UI: Selector to choose how many rows to display, in each report footer

Excellent work SteveG, again a small but great improvement to Piwik usability, which makes the UI much more efficient and less frustrating in terms of data analysis... :)

And it is extremely cool to view 500 visits at once in the visitor log!

comment:9 Changed 2 years ago by matt (mattab)

(In [5899]) Refs #2461

  • Enabling new controller for ecommerce product/category reports

comment:10 Changed 2 years ago by matt (mattab)

(In [5907]) Refs #2461

  • Fixing bug for Pages > tables, where a click to load a sub directory would trigger handleLimit and add the controller multiple times below each other
  • Adding possibility to select 500 rows
  • Disabling controller for the plugins report

comment:11 Changed 2 years ago by matt (mattab)

(In [5918]) Refs #2461

  • Previous commit disabled the selector on non actions tables by mistake

comment:12 Changed 2 years ago by EZdesign (BeezyT)

That's an awesome feature! Makes the reports much more usable and also looks nice. People have been asking me for this a number of times.

Only one minor suggestion: Wouldn't it be cool if the arrow flipped upwards when the selection is opened?

comment:13 Changed 2 years ago by EZdesign (BeezyT)

I noticed some problems with the JS.

  • The body mouseup event registered in datatable.js for the feature is never unbound. Shouldn't it be only bound after opening the dialog and unbound after closing it?
  • Binding the event to the body is problematic in Chrome. The body does not strech over the entire window but only as far as there is content. If you click the lower area of the window, the boxes don't close. You could use document instead of body.
  • The box can be opened on two tables if there are two on the page. This is connected to the overall event handling I already commented on.

comment:14 Changed 2 years ago by matt (mattab)

@Timo should we reopen the ticket, or open a different for the small changes/bugs you reported?

comment:15 Changed 2 years ago by EZdesign (BeezyT)

I would reopen it.

comment:16 Changed 2 years ago by matt (mattab)

I prefer not to reopen since feature works OK and is already released, but created a ticket with your suggestions in: #3150

comment:17 Changed 23 months ago by matt (mattab)

(In [6454]) Refs #2461 Reverting 2 parts of [5891] which caused this bug: Fixes #3167

It seems widgets don't need to default to filter_limit=10 ?

Note: See TracTickets for help on using tickets.