Opened 3 years ago

Closed 15 months ago

#2465 closed New feature (fixed)

Page Overlay - Analytics Overlay on your site! (Aka in-site analytics)

Reported by: matt Owned by: EZdesign
Priority: critical Milestone: 1.10 - Piwik 1.10
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt)

In order to show analytics data as an overlay, we have to set up a cross-domain communication protocol. The aim of this ticket is to complete a simple version of the feature that provides extensible mechanisms for the communication. Based on this, we can add more things to it.

Page Overlay displays a block around each link showing the % of clicks on this link. the user can still browse the website. On the left a sidebar displays the key statistics for the currently viewed page. It also easily allows the user to open the Page Transitions report and the Row evolution historical report for this particular page.

See #3530 List of Page Overlay Improvements for more info and the current state of the art!

Change History (100)

comment:1 Changed 3 years ago by matt (mattab)

From EZDesign:

I did some research on in-page analytics. Sounds very interesting.

But as it turns out, manipulating the iframe is far from easy to do. I think, I figured out how Google does it and posted it as a reply to a stack overflow question:

http://stackoverflow.com/questions/5210897/how-does-google-analytics-in-page-analytics-work/

I think it's quite problematic, that Google injects something the user doesn't really want, which demonstrates what kind of power Google has. I think this is not really a problem in our case, because we don't inject it, the users do (from their servers which are under their control).

In general, is this feature something we want? It definately is a piece of work, but it's quite a fancy feature. Seeing how much people like to be close to their visitors (i.e. Live), this should be received well!

comment:2 Changed 3 years ago by matt (mattab)

Timo, in page analytics would be a great feature to have for sure... especially since we can do it with the current data set and don't need to track more data.

The main limitation of this feature I think is that it doesn't differentiate few places linking to the same URL, so you don't know if users clicked mostly on top link or bottom link to "Contact us". But I guess we could somehow fix this issue later on, by storing some kind of unique ID for the DOM node being clicked, and add this field in the log_link_visit_action table ;) this would be hard code but I think possible without changing too many things. Anyway, not for V1!!

We probably could not pre-process the data, so it would be read from the logs directly (still fetched from an API function). Performance wise, we don't have an INDEX on the field idaction_url_ref so GROUP BY on this field will be pretty slow. We could add the INDEX, or maybe just "recommend" users to do it if they find the feature slow to use...? Adding the index for everybody sounds not ideal since it would have a non trivial performance/disk space overhead. But, it might work fine without it for most users anyway!

Also there will be some interesting DOM manipulation to detect all links to another URL (and normalizing URLs in the page transforming ../ etc. in the full URL).

Note that in Piwik we record the URL after removing some URL parameters. You can call getSiteFromId() and then look at excluded_parameters attribute to have the list of all excluded parameters. It is important to remove these from the links detected on the page to ensure you can match the same URLs. Also, common session parameters are excluded (see API SitesManager.getExcludedQueryParametersGlobal()) as well as Piwik campaign parameters (see campaign_var_name and campaign_keyword_var_name in global.ini.php).

Note that I have tried GA in page analytics on 3 different GA accounts but it didn't work in any of them... so I feel like the other guy in stackoverflow "The answer to 'how does it work' is 'it doesnt work'" ;)

Regarding how it works, I haven't looked into it but my first idea would not be to do iframe overlay, but to inject additional DOM elements that would show up on Hover and show the data for each link... Not sure if that would work or if iframe idea is better?

I think that, if we implement this feature, we'll need the "filter" dropdown as well, without it the page would look too busy and full of data maybe..

It would be great & useful & fun feature :)

PS: see also: https://www.google.com/search?q=webtrends+smartview

comment:3 Changed 3 years ago by matt (mattab)

  • Milestone changed from Feature requests to 1.x - Piwik 1.x

comment:4 Changed 18 months ago by EZdesign (BeezyT)

  • Description modified (diff)
  • Milestone changed from 1.x - Piwik 1.x to 1.9.x - Piwik 1.9.x
  • Owner set to EZdesign

comment:5 Changed 18 months ago by EZdesign (BeezyT)

The current working title of the feature is "Insight" or "Page Insight". We recently started using the word "Insight" for intelligent alerts, which would probably be a better way to use it. So we might want to come up with a better name.

Others call the feature "in-site analytics" or "on-site analytics". One suggestion I have is "Piwik Overlay" - but in the menu, it would be shortened as "Overlay". Or maybe "Page Overlay"?

Every comment is appreciated.

comment:6 Changed 18 months ago by EZdesign (BeezyT)

(In [7223]) refs #2465: Starting the Insight plugin (in-site analytics)

This is the code I wrote about a year ago :)

There are several things that will be changed / removed but it's still good to have it in SVN - that's why I commit it like this.

comment:7 Changed 18 months ago by EZdesign (BeezyT)

(In [7224]) refs #2465: removed code for resolutions overlay - it turned out to be not that useful. maybe we can rethink it in the future.

comment:8 Changed 18 months ago by EZdesign (BeezyT)

(In [7225]) refs #2465 svn properties for new files

comment:9 Changed 18 months ago by EZdesign (BeezyT)

(In [7226]) refs #2465 removed alias domain normalization. it's now consistent with the behavior of transitions which is good for reusing the transitions report.

comment:10 Changed 18 months ago by EZdesign (BeezyT)

(In [7227]) refs #2465, refs #3332: using Transitions for getting the following pages in Insight

comment:11 Changed 18 months ago by EZdesign (BeezyT)

(In [7228]) refs #2465 Insight is starting to be cool

  • highlight links on hover, displaying a border and the absolute number of clicks. also, the bubble (along with all other bubbles for links to the same url) is highlighted and the url is shown in the status (lower right corner)
  • bubbles are updated when links are hidden or added. this is useful for drop-down navigations or ajax content.
  • code formatter applied (some whitespace changes)

comment:12 Changed 18 months ago by matt (mattab)

  • Summary changed from In page analytics to Page Insights

Just an idea while I think of it:

  • it would be great to also show a link to open Transitions popover. I will review in more details later.
  • also would be great to see a link to Row Evolution, as it shows historical evolution

Maybe these 2 could be next to the 2 icons, written in grey, below the list of Metrics, in a new section "More insights on this Page:" ?

comment:13 Changed 18 months ago by EZdesign (BeezyT)

(In [7261]) refs #2465 improved efficiency of insight tracker extension.

you can review piwik.js now, i don't plan to change it any more.

comment:14 Changed 18 months ago by EZdesign (BeezyT)

When you open an insight session, you get JS errors like this (at least in Chrome, I haven't checked other browsers):

Unsafe JavaScript attempt to access frame with URL http://piwik.server/index.php?module=CoreHome&action=index&idSite=1&period=week&date=2012-06-24#module=Insight&action=index&idSite=1&period=week&date=2012-06-24 from frame with URL http://web.site/path/. Domains, protocols and ports must match.

It is thrown in piwik.js / getReferrer (line 640) because Piwik is checking the referrer of the parent document, which is the Piwik UI. The same origin policy doesn't allow that.

Who knows how we can avoid that?

comment:15 Changed 18 months ago by EZdesign (BeezyT)

(In [7262]) refs #2465 using piwikHelper.ajaxCall to build ajax call. it now works for date ranges as well.

comment:16 Changed 18 months ago by EZdesign (BeezyT)

(In [7263]) refs #2465

  • FULL SCREEN MODE!
  • smoother handling of the case when there are no pageviews for the current url
  • hovering the bubbles highlights the links as well
  • safer repositioning of bubbles (timeout instead of interval)
  • adding breakpoints to the current url

comment:17 Changed 18 months ago by matt (mattab)

(In [7306]) Refs #2465
Fixing JSLINT errors + packaging changes in piwik.js in the minified script

Note there are still 2 JSlint errors.

PS: Timo, I will carefully review your work on this ticket after 1.9.1 is out!

comment:18 Changed 18 months ago by matt (mattab)

  • Milestone changed from 1.9.x - Piwik 1.9.x to 1.9.2 - Piwik 1.9.2
  • Summary changed from Page Insights to Page Insights V1

This ticket will ideally be closed on Nov 15th, then we could reopen a new one with the pending new features and ideas for improvements.

comment:19 Changed 18 months ago by EZdesign (BeezyT)

(In [7392]) refs #2465

  • removed hardcoded domain (this is what caused the error on the demo and all other piwik instances)
  • force iframe height in firefox (height:100% doesn't work)

comment:20 Changed 18 months ago by EZdesign (BeezyT)

(In [7393]) refs #2465

  • this time, forcing the iframe height is included in the commit
  • client side url normalization: remove excluded parameters

comment:21 Changed 18 months ago by EZdesign (BeezyT)

(In [7405]) refs #2465 Insight

  • links to the current url get a bubble as well
  • limit for the number of pages loaded from the API can be configured
  • ready for translation
  • url normalizer doesn't remove the hash part anymore (which corresponds to the latest behavior of the tracker)

comment:22 follow-up: Changed 18 months ago by EZdesign (BeezyT)

Here are some things I'd like to hear your comments about:

  • As mentioned before, the name Insight would be better for intelligent analysis and alerts. Further, "Overlay" might be a better name for this plugin. How do you feel about renaming it Overlay? This would also be more suitiable in combination with heatmap.
  • The data quality in Transitions and Insight would be improved a lot if the tracker would not record outlinks and downloads as previous actions. When a visitor clicks multiple download links on one page, only the first one will show up in Transitions and Insight because for the other clicks, the previous action was the download made before. Would it be a good idea (and doable) to track this differently - i.e. when a download/outlink occurs after a pageview, keep the pageview as the previous action for the next download/outlink?
  • There are commented out test cases in client/urlnormalizer.js. Obviously, that's not the right place for them. But where would be the right place?

comment:23 Changed 18 months ago by EZdesign (BeezyT)

Could you please release a beta so I can do some more tests?

comment:24 Changed 18 months ago by EZdesign (BeezyT)

(In [7418]) refs #2465 Insight

  • new action: open in new tab - opens Insight session without an iframe
  • handle excluded parameters when loading the sidebar and following pages data
  • highlighting of linked images works properly now
  • tooltip showing the domain of the iframe

comment:25 Changed 18 months ago by EZdesign (BeezyT)

(In [7419]) refs #2465

  • renaming menu item to "Page Overlay", putting it under Actions
  • config option to disable framed mode altogether (can be used when websites contain frame busters)
  • fixed error for anonymous user
  • loading message in framed mode

comment:26 Changed 18 months ago by EZdesign (BeezyT)

In Piwik_Insight_API::getExcludedQueryParameters I had to catch an exception that is thrown in Piwik_SitesManager_API::getExcludedQueryParametersGlobal when the user has no admin access at all (Piwik::checkUserHasSomeAdminAccess). In this case, excluded parameters are not handled by Insight. This means that when using anonymous access, excluded parameters don't work.

Wouldn't it better to check in Piwik_SitesManager_API::getExcludedQueryParametersGlobal whether the user has some view access instad of some admin access? Or what's the reason for checking admin access?

comment:27 Changed 18 months ago by EZdesign (BeezyT)

(In [7420]) refs #2465

  • links in the pages report can be opened in insight instead of a new tab (to enable, use config option insight_launch_from_pages_report)
  • links containing an image should really work properly now
  • plugin description set

comment:28 Changed 18 months ago by matt (mattab)

(In [7426]) Testing Page Overlay on demo Refs #2465

comment:29 in reply to: ↑ 22 Changed 18 months ago by matt (mattab)

  • Summary changed from Page Insights V1 to Site Overlay - Analytics Overlay on your pages!
  • As mentioned before, the name Insight would be better for intelligent analysis and alerts. Further, "Overlay" might be a better name for this plugin. How do you feel about renaming it Overlay? This would also be more suitiable in combination with heatmap.

Overlay sounds like a plan indeed. It is more general and will allow us to easily include other concepts in it. Do you mind renaming all files and the plugin itself? It's quite a job but definitely worth it. we are regretting not doing it for PDFReports which should be called ScheduledReports.

  • The data quality in Transitions and Insight would be improved a lot if the tracker would not record outlinks and downloads as previous actions. When a visitor clicks multiple download links on one page, only the first one will show up in Transitions and Insight because for the other clicks, the previous action was the download made before. Would it be a good idea (and doable) to track this differently - i.e. when a download/outlink occurs after a pageview, keep the pageview as the previous action for the next download/outlink?

it's great data value to know, from which page URL downloads were made. Because I'd like to know, where latest.Zip was downloaded from exactly. This is why it would be useful to be able to click on a File or Outlink in Transitions, to get the referrers for this download/outlink.

But you are right, that we should not track referrers when they are downloads or outlinks as it does not make as much sense!! Here is my proposed patch which I haven't tested (tests take still forever for me, yet to get a SSD ;)) but it will work I think:

+++ core/Tracker/Visit.php	(revision )
@@ -349,7 +349,13 @@
 		$sqlActionUpdate = '';
 		if($idActionUrl !== false)
 		{
+			// In Transitions and Site Overlay reports,
+			// A given Action being looked at can only have an internal referrer of Pageview or Search.
+			// Downloads and Outlinks will not be tracked as "previous action".
+			if( in_array($actionType, array(Piwik_Tracker_Action::TYPE_ACTION_URL, Piwik_Tracker_Action::TYPE_SITE_SEARCH)) )
+			{
-			$valuesToUpdate['visit_exit_idaction_url'] = $idActionUrl;
+				$valuesToUpdate['visit_exit_idaction_url'] = $idActionUrl;
+			}
 			$sqlActionUpdate .= "visit_total_actions = visit_total_actions + 1, ";
 		}
 		if(!empty($idActionName))


EDIT: we should remove sum_time_spent on all outlinks and downloads Datatables and expected/ API outputs since it currently contains sum_time_spent, and when this patch is applied they all become zero.

  • There are commented out test cases in client/urlnormalizer.js. Obviously, that's not the right place for them. But where would be the right place?

We have javascript tests running in: piwik/tests/javascript/

See: http://dev.piwik.org/trac/browser/trunk/tests/javascript/index.php#L425

You can create test groups, and easily add powerful unit tests to all the new Javascript code. If you read through the file once you should get a good idea of how tests work. I have tried to maintain the tests coverage high of piwik.js since Anthon's initial great work on these JS tests. +1 to add solid unit tests coverage for the tricky URL normalization parts!

Last edited 18 months ago by matt (previous) (diff)

comment:30 Changed 18 months ago by matt (mattab)

Timo, you did it again!! An awesome new feature designed in a very nice fashion... I can't stress enough how great it feels :-)

I will put the review first of the UI and some suggestions for changes and tweaks to make UI better and more usable - I will post code review in a few hours.

UI/UX

  • I like the "Page: /XXXX" at the top of the iframe. However it takes up one line which removes pixels for the initial view of Transitions feature. I think the report would look much nicer, if the "Page Name" being looked at was actually displayed inside a new BOX similar to the "Calendar" that would read "Page: /XXXX" similarly but this way, it would not take an extra line.
    • The box would also highlight the Page URL being looked at and would clarify what this is about. Even maybe it should say "Page Overlay for: /XXX" ?
  • In the left sidebar:
    • it would be nice if "View Transitions" and "View Page Evolution" were available with icon+text similar to Full Screen link, and would open the Row evolution/Transitions report as an overlay on top of the Site Overlay. This would be Uber Awesome.
    • "Open in new tab" can use same CSS style as "Go Full screen" and use the std piwik orange-link icon
  • I Love the full screen mode, and the Awesome display on overlay on the website with no extra parameter!
    • is it possible to ask a new mode: Trigger the overlay reports by calling http://example.org/#overlay (and default to the "User default" date + period, see ), without requiring to have Referrer?
    • Could we display a half transparent Box that would invite user to click, which would then expand into an infobox, overlaid on the website (Maybe at bottom left or right?), that would show: the date range being looked at, and the list of metrics.
      • This overlay box in the full screen mode, could later contain the calendar to let the user change the date that was pre-selected when using #overlay
        • In general, the calendar should be displayed in the sidebar in the "Full screen mode" so that users always see which period the report is applied for. This is quite key in Piwik to always leave calendar or date displayed (like in Transitions)

Bugs Reports

  • On demo it does not show the number of clicks on the download file http://piwik.org/latest.zip - However, these clicks are shown correctly in the Transitions report so the underlying data is OK. It's important to see clicks to files in the overlay repotr since this is an excellent feature of Piwik VS GA because we do automatic file tracking :)
    • Same for outlinks. Would be nice to see how many click on these buttons to fb/twitter for example (and could be very useful for checking advertising campaign queries)
    • this is why I think the #overlay is very important. A webmaster could simply check the effectiveness of the marketing campaign from one page by going to the page and type #overlay and start his piwik experience from there!

in Chrome: Unsafe JavaScript attempt to access frame with URL https://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=year&date=2012-11-08#module=Insight&action=index&idSite=7&period=year&date=2012-11-08 from frame with URL http://forum.piwik.org/. Domains, protocols and ports must match.

  • When Piwk is used over SSL the Page Overlay should load the site in iframe over SSL.
  • Data accuracy: as suggested by email, I think Form Post url discovery would be very nice to have!
  • When the page does not load for any reason, could you display a NOTICE message (in a JS Alert box or in the screen) such as "Page Overlay Report could not load for this website. [List here short troubleshooting or link to FAQ?]"
    • If we detect that Piwik is currently loaded over SSL, and the site doesn't load, we can suggest that the site does not support HTTPS and suggest them to use Piwik over http to view site overlay?


Last edited 18 months ago by matt (previous) (diff)

comment:31 Changed 18 months ago by matt (mattab)

(In [7428]) Refs #2465 - Only require some view access to get excluded parameters
As per Timo's suggestion in http://dev.piwik.org/trac/ticket/2465#comment:26

please remove the exception handler

comment:32 follow-up: Changed 18 months ago by EZdesign (BeezyT)

Thanks for the feedback. It's a lot of stuff to go through...

Let's start with some comments about what you wrote:

in Chrome: Unsafe JavaScript attempt to access frame with URL https://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=year&date=2012-11-08#module=Insight&action=index&idSite=7&period=year&date=2012-11-08 from frame with URL http://forum.piwik.org/. Domains, protocols and ports must match.

See http://dev.piwik.org/trac/ticket/2465#comment:14. It's a general tracker issue and not connected to Page Overlay.

"Open in new tab" can use same CSS style as "Go Full screen" and use the std piwik orange-link icon

I created an icon for it and it has a css style. You probably need to delete tmp/assets/* and hit refresh.

Attachment overlay - links appended bottom right.png​ added

That shouldn't happen... Can you tell me exactly which OS and browser you're using?

The overlay for piwik.org Language selector menu bubbles are displayed, for items that are hidden. It would be nice if the hidden Javascript menu bubbles were displayed only when user hovers on the menu inside the Page Overlay Piwik report. The bubbles are currently always displayed.

That should work. I will investigate why it doesn't work in this case. I'm using jquery's .is(':visible') to tell wether a link is hidden and it works fine on the pages I tested so far.

is it possible to ask a new mode: Trigger the overlay reports by calling http://example.org/#overlay (and default to the "User default" date + period, see ), without requiring to have Referrer?

It's possible but using the deafult date range probably isn't a good idea. The default date range is usually yesterday and picked to show you the latest stats. Normally, you want to see the Page Overlay for a longer period to have more data. So I will postpone this until we have a full sidebar including a date selection in the "new tab" mode. Otherwise, this will just cause frustration. Unfortunately, that's pretty low on my priority list.

I will now focus on the items with top priority and get as many of them done as I can for the release next week.

How do you feel about including Page Overlay in the release as a disabled plugin and write in the blog post that it's a beta release and people can enable it to check it out and tell us about problem they have on their websites. There will be problems for sure because people build weird websites...

comment:33 in reply to: ↑ 32 Changed 18 months ago by matt (mattab)

Replying to EZdesign:

Thanks for the feedback. It's a lot of stuff to go through...

Let's start with some comments about what you wrote:

in Chrome: Unsafe JavaScript attempt to access frame with URL https://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=year&date=2012-11-08#module=Insight&action=index&idSite=7&period=year&date=2012-11-08 from frame with URL http://forum.piwik.org/. Domains, protocols and ports must match.

See http://dev.piwik.org/trac/ticket/2465#comment:14. It's a general tracker issue and not connected to Page Overlay.

Attachment overlay - links appended bottom right.png​ added

That shouldn't happen... Can you tell me exactly which OS and browser you're using?

I couldn't reproduce again and actually didn't mean to attach it..

That should work. I will investigate why it doesn't work in this case. I'm using jquery's .is(':visible') to tell wether a link is hidden and it works fine on the pages I tested so far.

Cool! you can test on the demo, idsite=1

It's possible but using the deafult date range probably isn't a good idea. The default date range is usually yesterday and picked to show you the latest stats. Normally, you want to see the Page Overlay for a longer period to have more data. So I will postpone this until we have a full sidebar including a date selection in the "new tab" mode. Otherwise, this will just

cause frustration. Unfortunately, that's pretty low on my priority list.

Agree that waiting for calendar is better for #overlay mode.
The sidebar expandable on click in the Full screen mode will be a Killer, but indeed there are more important things first!

I will now focus on the items with top priority and get as many of them done as I can for the release next week.

+1

How do you feel about including Page Overlay in the release as a disabled plugin and write in the blog post that it's a beta release and people can enable it to check it out and tell us about problem they have on their websites. There will be problems for sure because people build weird websites...

That's the plan I think! I would really like to leave it up for a few weeks with all documentation, but just have optin users so we get quality bug reports.

comment:34 follow-up: Changed 18 months ago by matt (mattab)

Continuing the review...

User Interface Feedback:

  • Add icon for Site Overlay in the Pages Reports Rows along with Transitions+Row Evolution?...
    • Alternatively, and it might even more awesome (!!) we could link from Transitions to the Site Overlay: indeed Overlay will show more "following internal pages" so this is relevant. We could link to Overlay from a new icon in the Popover title. (this would close the Transitions popover and reload the menu to load Overlay)
    • Also in Row Evolution, we could link to Site Overlay (this would close the Transitions popover and reload the menu to load Overlay -- or we could open overlay in a new tab...)
  • Your two icons look really good! Are you icon designer as well on your spare time? ;)
  • It would be great to have the same "cool icon style" for Row Evolution icon and Transitions icon. Would it be possible? :)
    • Then we could replace the existing icons in "Pages" table reports. They could be Grey by default, and Blue on Hover which would look nice and more exciting to click on.
    • These two icons would also be displayed below "Open in a new tab" in the Overlay Sidebar and would allow a user to open transitions/Row evolution popover! NICE!
  • UI: "Open in new tab" should be "Open Overlay in new tab" for more clarity as what the feature does


Bug reports

  • When the page loaded in the iframe does not have the piwik.js loaded (for example if the alias URL is wrong or the homepage does not have piwik tracking code) then the overlay repotr will fail without message. Instead, we should display an error or warning message explaining that the Piwik Javascript file was not found on this website.
  • Missing URL in hash tag: When the Page Overlay is loaded, please also update the URL Hash with the currently looked at page URL. This way we can manually change it.


This is useful when I have to manually change it to keep using the feature. For example, when none of the links on the current page link to a page which has the piwik tracker, or when the default alias URL does not have the piwik.js on it and so there is a JS error, and if I click on the links it simply opens the clicked page in the current tab


comment:35 in reply to: ↑ 34 ; follow-up: Changed 18 months ago by EZdesign (BeezyT)

Replying to matt:

  • Add icon for Site Overlay in the Pages Reports Rows along with Transitions+Row Evolution?...

Launching Overlay from the pages report is useful for large websites. But I didn't want to add a third icon because of the space it would take. If you want to connect Overlay and the pages report, you can use the setting insight_launch_from_pages_report. If you enable it, the links in the pages report won't open new tabs but will start an Overlay session.

  • Alternatively, and it might even more awesome (!!) we could link from Transitions to the Site Overlay: indeed Overlay will show more "following internal pages" so this is relevant. We could link to Overlay from a new icon in the Popover title. (this would close the Transitions popover and reload the menu to load Overlay)

Great Idea!

  • Also in Row Evolution, we could link to Site Overlay (this would close the Transitions popover and reload the menu to load Overlay -- or we could open overlay in a new tab...)

Why would you want to link from row evolution? It's not really connected. I think putting a row evolution link in Overlay is important but the other way around not so much.

  • It would be great to have the same "cool icon style" for Row Evolution icon and Transitions icon. Would it be possible? :)

I spent quite some time designing the current ones and think they are the best I can do. I'm really not much of a designer. I'm happy to let a designer come up with other ideas. But I think the icons in the actions report should be less visible than the blue and I'm pretty happy with them...

  • Missing URL in hash tag: When the Page Overlay is loaded, please also update the URL Hash with the currently looked at page URL. This way we can manually change it.

I tried to do that but it totally screws up the history. Using the back and forward buttons works because they change the iframe location but if we change the location of the parent frame, there will be weird effects. I tried for over an hour to get it right but couldn't do it.

This is useful when I have to manually change it to keep using the feature. For example, when none of the links on the current page link to a page which has the piwik tracker, or when the default alias URL does not have the piwik.js on it and so there is a JS error, and if I click on the links it simply opens the clicked page in the current tab

This is why I added the config option to link from the pages report. If your page does something strange, you can use that. Maybe we can even add another option to remove Page Overlay from the menu so it will be only accessible from the actions report? You could use that when your home page doesn't contain the Piwik tracker because starting the session won't work in this case. What do you think?

comment:36 Changed 18 months ago by EZdesign (BeezyT)

  • Summary changed from Site Overlay - Analytics Overlay on your pages! to Page Overlay - Analytics Overlay on your site! (Aka in-site analytics)

comment:37 Changed 18 months ago by EZdesign (BeezyT)

I created a ticket with possible improvements. This will add some structure to our discussion: #3530

I also have a private note with about 8 screen heights worth of stuff but what's in the ticket should be a fair start :)

comment:38 Changed 18 months ago by EZdesign (BeezyT)

(In [7431]) refs #2465

  • finally figured out how to use browser history + location parameter. wohooo! works perfectly in chrome/safari and almost perfectly in firefox; will do more tests later.
  • minor lang changes

comment:39 in reply to: ↑ 35 ; follow-up: Changed 18 months ago by matt (mattab)

  • Description modified (diff)

Why would you want to link from row evolution? It's not really connected. I think putting a row evolution link in Overlay is important but the other way around not so much.

It would be cool to have the link in the popover, at the bottom, because it would help feature discoverability... but not as useful as Transitions>Overlay indeed

This is useful when I have to manually change it to keep using the feature. For example, when none of the links on the current page link to a page which has the piwik tracker, or when the default alias URL does not have the piwik.js on it and so there is a JS error, and if I click on the links it simply opens the clicked page in the current tab

This is why I added the config option to link from the pages report. If your page does something strange, you can use that. Maybe we can even add another option to remove Page Overlay from the menu so it will be only accessible from the actions report? You could use that when your home page doesn't contain the Piwik tracker because starting the session won't work in this case. What do you think?

  • OK that history cannot work with iframes history as well, thanks for trying anyway
  • About my bug: I was using Piwik correctly: I set "Alias URL" to example.com but I was only tracking example.com/dir -- so when Overlay loaded with example.com it failed and I was stuck and could not use Overlay.
    • Solution to this bug: When user click on Actions > Overlay, could we load by default the "Top Page URL" rather than the first Alias URL?
Last edited 18 months ago by matt (previous) (diff)

comment:40 Changed 18 months ago by EZdesign (BeezyT)

(In [7434]) refs #2465

  • discover links that are added by JS, remove bubbles for links that have been removed
  • safer timeout/resize handling
  • adding some comments
  • code formatter applied (white space changes)

comment:41 in reply to: ↑ 39 ; follow-up: Changed 18 months ago by EZdesign (BeezyT)

Replying to matt:

  • I was using Piwik correctly: I set "Alias URL" to example.com but I was only tracking example.com/dir -- so when Overlay loaded with example.com it failed and I was stuck and could not use Overlay.

That's the exact problem we were facing with my client's website. That's why I added the config option and they launch it from the actions report. I think it would help to add another config option that would hide Overlay from the menu. With these two options combined you could make it only accessible via the pages report and this way make sure that it is only openend for pages tracked by piwik. What do you think?

  • Solution to this bug: When user click on Actions > Overlay, could we load by default the "Top Page URL" rather than the first Alias URL?

What is the "Top Page URL"? The one with most hits? Might be counter-intuitive in many cases. The solution above is the best we could come up with. Maybe there's something we're missing...

comment:42 Changed 18 months ago by EZdesign (BeezyT)

Can you tell me why "Page Overlay" appers left of "Downloads" in the menu? It has order 60 while "Downloads" has 7.

comment:43 Changed 18 months ago by EZdesign (BeezyT)

(In [7435]) refs #2465

  • in addition to using jquery's .is(':visible'), check for visibility==hidden to determine whether a link is visible.
  • this should fix the issues where the bubbles are shown even though the links are not shown at the moment. please deploy on the demo and check.

comment:44 follow-up: Changed 18 months ago by EZdesign (BeezyT)

Attachment Overlay - links that are behind hovered menu are still displayed.png added

I don't think there's a way to avoid that. Does anybody know how we could tell (efficiently) when a link is behind another dom element? (By the way, Google's JS devs don't.)

comment:45 Changed 18 months ago by EZdesign (BeezyT)

(In [7436]) refs #2465

  • using filter_limit=-1 when requesting the api from the overlay session
  • this should fix the bug that there's no bubble next to latest.zip on the demo (the problem was that following pages come first and if there is a certain number of them, all outlinks and downloads are cut off)

comment:46 Changed 18 months ago by matt (mattab)

(In [7438]) Refs #2465 Adding Insight to list of non tested plugins for integration tests... once the API is final and all other core things are done, it wiill be nice to add integration tests (but better focus on functionnality first)

comment:47 Changed 18 months ago by matt (mattab)

(In [7439]) Refs #2465 Adding Insight to list of non tested plugins for integration tests... once the API is final and all other core things are done, it wiill be nice to add integration tests (but better focus on functionnality first)

comment:48 Changed 18 months ago by matt (mattab)

(In [7440]) Refs #2465 Will release latest beta on demo!

comment:49 Changed 18 months ago by matt (mattab)

UI / UX Suggestions of small changes that will make feature more fun and usable:

  • In the bottom of the sidebar:
    • i would like to see a new discreet option "Show Clicks instead of % clicks" because, for many users it makes more sense to look at number of raw clicks rather than percentage. Also the number can be more visual than the percentage. In particular I find bubbles such as "0.6%" confusing because it takes many digits yet is irrelevant.
    • Could be fun to have similar a mode "Highlight All Links" that would put a dark grey overlay on the site and only show the bubbles. For example on one site I track there are so many images etc. that the bubles are hard to see (especially which ones are high). Having a simple darker overlay for the site, would help (and I'd just like to turn it off/on quickly as a UI helper tool to better discover the Overlay report in general)
  • the full screen mode is great!! In fact it's much better than non full screen, by default it's too distracting I find. So I think full screen is key to having a good "Overlay" report experience.
  • In full screen mode, I have some suggestions of small UX changes that will improve usability:
    • Hitting ESC should close full screen mode (escape is like a click on "close full screen")
    • it would be nice to display hte "Popover close" icon in the top left (in sidebar) so that a user could easily "close" the full screen mode and go back to piwik (or hit ESC or click Exit full screen). The more easy we make to exit the full screen the more it will be used!
    • in full screen, there should be a way to "collapse" the sidebar. This is because, some websites are distorted with the sidebar on the left
    • please add &fullscreen or similar, to the Hash tag so that we can copy paste full screen reports by email and IM


  • When a link is hovered, the other similar links on the page are highlighted in orange. That's great. I propose that, when the bubble is clicked, the orange border also appears around all same links on the page. This way we could see at a glance the other links sharing this number of clicks.

EDIT: Clicking the bubble again of any of these same links would "toggle / hide" these borders on the same link.

Last edited 18 months ago by matt (previous) (diff)

comment:50 Changed 18 months ago by matt (mattab)

Very nice recent changes, well done! The latest.zip stats now display and shows 16% conversion rates for the download from homepage, very cool!

comment:51 in reply to: ↑ 44 Changed 18 months ago by matt (mattab)

Replying to EZdesign:

Attachment Overlay - links that are behind hovered menu are still displayed.png added

I don't think there's a way to avoid that. Does anybody know how we could tell (efficiently) when a link is behind another dom element? (By the way, Google's JS devs don't.)

Umh, that's a tricky one... Well, we could keep track of a list of rectangles, that are overwriting others, and use this array as a "blacklist" to hide (bubbles inside the blacklist X-Y but not a children of the DOM node so they must be behind it) ?

comment:52 in reply to: ↑ 41 Changed 18 months ago by matt (mattab)

What is the "Top Page URL"? The one with most hits? Might be counter-intuitive in many cases. The solution above is the best we could come up with. Maybe there's something we're missing...

Yes the one with most hits. but we don't really need this yet, as I would prefer removing submenu by default (worth keeping on the ideas list to to load the "Top Page URL" as it would be useful for those enabling the menu).

  • I was using Piwik correctly: I set "Alias URL" to example.com but I was only tracking example.com/dir -- so when Overlay loaded with example.com it failed and I was stuck and could not use Overlay.

That's the exact problem we were facing with my client's website. That's why I added the config option and they launch it from the actions report. I think it would help to add another config option that would hide Overlay from the menu. With these two options combined you could make it only accessible via the pages report and this way make sure that it is only openend for pages tracked by piwik. What do you think?

Agreed these 2 options are important. Overlay submenu does not feel like it belongs like other "Action types"...

I have thought hard about this and here is what I think would be best functionnality:

  • Config Option (later possibly a User preference) to Display the "Actions > Overlay" menu --> Disabled by default (less UI clutter)
  • By default, clicking on the Page Name or Page Url should I think open Page Overlay Full Screen!!! YEP!
  • The orange icon should still link to the URL itself (since it's the meaning of the icon)
    • On hover on the orange icon, display tooltip "Open this $actionType in a new tab". This way we are consistent and display the tooltip on all possible actions for the row.
  • On Hover on a Page name, the tooltip displays "Open Page Overlay for $pageNameOrUrlpath"
    • The page overlay would load in the same tab, opened full screen by default. Back button would work and return to Page report.
    • It is similar to insight_launch_from_pages_report=1 except it would open full screen + show tooltip + orange icon still link to URL in new tab!

What do you think about this proposal?

comment:53 follow-up: Changed 18 months ago by matt (mattab)

(In [7443]) Refs #2465 Looks like a bug in the menu code, but 99 works...

comment:54 follow-up: Changed 18 months ago by EZdesign (BeezyT)

once the API is final and all other core things are done, it wiill be nice to add integration tests (but better focus on functionnality first)

Acutally Overlay doesn't really have an API. It's just a proxy for other API methods with cookie authentication. I'd rather write good test cases for Transitions.

i would like to see a new discreet option "Show Clicks instead of % clicks"

If you have 13472 clicks, it's too much text for the bubbles. Maybe we can show the total number in the lower right on hover?

Could be fun to have similar a mode "Highlight All Links" that would put a dark grey overlay on the site and only show the bubbles.

The "Color Overlays" would have the same effect with additional benefits. It's on the list of improvements.

Have you tried it on GA?

in full screen, there should be a way to "collapse" the sidebar. This is because, some websites are distorted with the sidebar on the left

Why not use the new tab feature when the sidebar distorts the website?

Attachment Overlay - links that are behind hovered menu are still displayed.png added

I don't think there's a way to avoid that. Does anybody know how we could tell (efficiently) when a link is behind another dom element? (By the way, Google's JS devs don't.)

Umh, that's a tricky one... Well, we could keep track of a list of rectangles, that are overwriting others, and use this array as a "blacklist" to hide (bubbles inside the blacklist X-Y but not a children of the DOM node so they must be behind it) ?

And how would you build such a list? Also keep in mind that DOM elements can be added, removed and repositioned at any time. I don't see any other way than processing every DOM element every two seconds. That would slow everything down a lot...

I would prefer removing submenu by default / clicking on the Page Name or Page Url should I think open Page Overlay Full Screen

First of all, it won't work for the page name because they are not URLs.

In general, I have to think about this for a while... Launching Overlay only from the pages report would be very different from the way other analytics tools do it. It would have andvantages but it would also make it harder to use for people coming from other tools because the workflow they know is opening it via the menu and then clicking throught the website.

comment:55 Changed 18 months ago by EZdesign (BeezyT)

(In [7444]) refs #2465

  • adding remove() method for following pages
  • it can be used to remove dom elements, timeouts and events. afterwards, a new implementation can be pasted into the console. this makes debugging without access to the server possible.

comment:56 in reply to: ↑ 53 Changed 18 months ago by EZdesign (BeezyT)

Replying to matt:

(In [7443]) Refs #2465 Looks like a bug in the menu code, but 99 works...

Doesn't work on the demo - at least not when signed in.

comment:57 Changed 18 months ago by EZdesign (BeezyT)

(In [7445]) refs #2465

  • Renaming Insight to Overlay
  • Includes a new minified piwik.js, generated as described in js/README. Please double-check whether the file is OK.
  • Servers that had the Insight plugin installed will need to delete it manually, right?

comment:58 Changed 18 months ago by EZdesign (BeezyT)

(In [7446]) refs #2465 this was missing in the last commit

comment:59 follow-up: Changed 18 months ago by EZdesign (BeezyT)

i would like to see a new discreet option "Show Clicks instead of % clicks"

If you have 13472 clicks, it's too much text for the bubbles. Maybe we can show the total number in the lower right on hover?

I just realized that this is nonsense. The absolute number is shown on hover. But the point that absolute numbers are too large for the bubbles is still valid.

comment:60 Changed 18 months ago by EZdesign (BeezyT)

(In [7447]) refs #2465

  • adding url normalizer tests to tests/javascript
  • note: two of the other test cases are failing (JSLint and tracking:"ecommerce view multiple categories")

comment:61 Changed 18 months ago by matt (mattab)

(In [7448]) Refs #2465 Will test on demo + Cleaning up Insight plugin from config file + filesystem on update

comment:62 Changed 18 months ago by matt (mattab)

(In [7449]) Refs #2465 piwik.js is different but looks like white space difference

comment:63 follow-up: Changed 18 months ago by EZdesign (BeezyT)

I tried the patch for tracking only pageviews as previous actions. It does the job but there is a problem:

Transitions relies on the fact that there are as many following actions as pageviews. This is used to derive the number of exits and to determine the height of the connections. Changing the tracking behavior requires a change in the display logic of transitions and (more imprtantly) i think it would require an additional query to derive the number of exits in transitions.

This is a quite though challenge but the data quality for a list of outlinks / downloads is really bad at the moment so we should try to do it somehow...

comment:64 follow-up: Changed 18 months ago by EZdesign (BeezyT)

How about we drop the approach to show Overlay inside Piwik completely?

  • From the pages report, we link to ?module=Overlay... instead of ?module=CoreHome...#module=Overlay...
  • This would always open in a new tab
  • The "Open in new tab" link would become "Hide sidebar".
  • We add a link box to website that contains "Show sidebar" and links back to ?module=Overlay...
  • To launch Overlay on the home page, we could add a widget that only contains this link.

Consequences:

  • No more menu item "Page Overlay"
  • Always full screen
  • Mode 1: piwik-url.com/?module=Overlay... with sidebar
  • Mode 2: acutal-website.com/... without sidebar
  • Mode 1 and 2 can be toggled, no matter how the session was started (would also work for #overlay later)

comment:65 Changed 18 months ago by EZdesign (BeezyT)

(In [7453]) refs #2465

  • when Piwik is used over SSL, load the website in the frame over SSL too
  • when nothing comes back from the iframe, show an error message after a timeout (8 seconds)
  • improved handling of overlayUrl a bit (though this should be obsolete soon when we only have full screen mode)

comment:66 Changed 18 months ago by EZdesign (BeezyT)

(In [7454]) refs #2465: followingpages.js improvements

  • don't use a css class to remember which links have been discovered anymore. websites might change the class.
  • when a link is displayed inline and has only child, use the child as a reference for the position

comment:67 Changed 18 months ago by EZdesign (BeezyT)

(In [7455]) refs #2465 minor bugfix for followingpages.js

comment:68 in reply to: ↑ 54 Changed 18 months ago by matt (mattab)

Could be fun to have similar a mode "Highlight All Links" that would put a dark grey overlay on the site and only show the bubbles.

The "Color Overlays" would have the same effect with additional benefits. It's on the list of improvements.

Have you tried it on GA?

I just did, it's pretty cool! I think the site behind should be even a bit darker. It would be nice to have, and useful help to the analysis

in full screen, there should be a way to "collapse" the sidebar. This is because, some websites are distorted with the sidebar on the left

Why not use the new tab feature when the sidebar distorts the website?

because it opens in a new website, and is much slower (have to wait page load again), than if the sidebar was simply collapsed... +1 for sidebar collapse!

Attachment Overlay - links that are behind hovered menu are still displayed.png added

I don't think there's a way to avoid that. Does anybody know how we could tell (efficiently) when a link is behind another dom element? (By the way, Google's JS devs don't.)

Umh, that's a tricky one... Well, we could keep track of a list of rectangles, that are overwriting others, and use this array as a "blacklist" to hide (bubbles inside the blacklist X-Y but not a children of the DOM node so they must be behind it) ?

And how would you build such a list? Also keep in mind that DOM elements can be added, removed and repositioned at any time. I don't see any other way than processing every DOM element every two seconds. That would slow everything down a lot...

It would work only on timer, indeed... Ok for not doing it, it's fine as it is!

In general, I have to think about this for a while... Launching Overlay only from the pages report would be very different from the way other analytics tools do it. It would have qandvantages but it would also make it harder to use for people coming from other tools because the workflow they know is opening it via the menu and then clicking throught the website.

Ok I let you think... I don't like "Overlay" in "actions" menu but I also agree that it would be nice to have it in one menu somewhere...

Note: To allow discover this feature further, we could even add row evolution in the "All Websites" dashboard and default the "Overlay" action to open the default Site URL overlay.

comment:69 in reply to: ↑ 59 Changed 18 months ago by matt (mattab)

Replying to EZdesign:

i would like to see a new discreet option "Show Clicks instead of % clicks"

If you have 13472 clicks, it's too much text for the bubbles.

I propose 14.5K or 1.1M (0 or 1 decimal based on space available)

There's a similar prettyfying function in Piwik::getPrettySizeFromBytes() used in DBStats report.

I think this would be awesome! many people like clicks more than % (and both separately are really useful)

comment:70 in reply to: ↑ 63 Changed 18 months ago by matt (mattab)

Replying to EZdesign:

I tried the patch for tracking only pageviews as previous actions. It does the job but there is a problem:

Transitions relies on the fact that there are as many following actions as pageviews. This is used to derive the number of exits and to determine the height of the connections. Changing the tracking behavior requires a change in the display logic of transitions and (more imprtantly) i think it would require an additional query to derive the number of exits in transitions.

This is a quite though challenge but the data quality for a list of outlinks / downloads is really bad at the moment so we should try to do it somehow...

Personnally I prefer the solutoin patch + wrong "Exit" data in Transitions rather than the current solution...

I agree it will create bit of wrong data in transitions for exits, but it's really cool to not miss clicks from pageA -> PageB because of intermediate downloads. People who need the exit rate for a given page can use the exit_rate from the Actions report. IN fact I'm sure they will...

I am not keen to add new queries to fix this. We would better even query the Page URL metrics and derive exits from there rather than add a new query...

But +1 for applying patch and figuring out what to do next, after ;)

comment:71 in reply to: ↑ 64 Changed 18 months ago by matt (mattab)

Replying to EZdesign:

How about we drop the approach to show Overlay inside Piwik completely?

  • From the pages report, we link to ?module=Overlay... instead of ?module=CoreHome...#module=Overlay...
  • This would always open in a new tab

That could be cool, but somehow I feel it's better how you did , and add a user option (bottom of sidebar?) "Start Overlay in Full Screen mode" recorded per user. This way I feel will be most usable and fit everybody (I would set to full screen default but many users prefer not to not have the "context" and whole thing change).

  • The "Open in new tab" link would become "Hide sidebar".

I wanted to suggest that too. But, it would also work when looking at piwik menu + overlay: it owuld be nice to hide sidebar there to at least display 100% of width even if piwik menu still take height space.

  • To launch Overlay on the home page, we could add a widget that only contains this link.

nice idea, to have a widget "Page Overlay" with an input field containing by default the top Page URL, when click "Open Overlay" button which would load the Overlay Full Screen.

  • We add a link box to website that contains "Show sidebar" and links back to ?module=Overlay...

When the overlay is viewed full screen, by default I would propose:

  • Show the OVerlay in the "Actions" Menu, maybe on the far right of the menu and with an icon, to show clearly it is a differnt kind of report? we would have to hack the menu but it should be possible... Thoughts about displaying "Page Overlay" on the far right Actions submenu?
  • Display the sidebar on the left by default
  • "Hide Sidebar" would slide-in the sidebar to the left. On hover on the left 20 pixels or so, an icon would allow to display sidebar again? Otherwise, back button would work too, to come back to previous Piwik reports for example.
    • Ideally the Hide Sidebar feature would also be available on a click on the sidebar itself, which would be a few pixels wide clickable sidebar.

In full screen a mode "Shadow website + Highlight link" will be amazing! I like the bubbles and borders and I think with a nice background color inside, and a black opacity overlay below, could look amazing and inviting for users to really SEE how "clickable" their website is, and what is being used. It's all about picking right colors now, see email ;)

  • Mode 1: piwik-url.com/?module=Overlay... with sidebar
  • Mode 2: acutal-website.com/... without sidebar
  • Mode 1 and 2 can be toggled, no matter how the session was started (would also work for #overlay later)
  • Mode 1) is also required for #3536 I believe, which will be awesome to have for Piwik Mobile to view Page Overlay
  • Mode 2) what is the different with #overlay or is it the same?

I would add:

  • Mode 0: default: Add "Page Overlay" to submenu far right, by default shows sidebar and piwik menu, add footer user setting to open fullscreen by default, URL would be piwik-url/?module=CoreHome..#module=Overlay

Ok it's a long talk here but it's important to get this right.... this could be a super useful analytics feature to allow to discover easy improvements to one's on-sit optimizations!

comment:72 follow-up: Changed 18 months ago by matt (mattab)

Bug report:

  • When looking at overlay for a site, I realize Overlay is really cool and want to look at another site overlay. The URL still contain the overlayUrl from the previous site, causing the message "You are attempting to open Page Overlay for the URL "http://www.X".

None of the URLs from the Piwik settings matches the link. Please add the domain there. }}}

  • overlayUrl should be removed when switching websites or clicking on any other menu
  • Message can be slightly improved:
    • If the user is admin for the site Piwik::isUserHasAdminAccess($idSite) then the message could link to: module=SitesManager&action=index with hash tag: #row5 for idsite=5 --> this way they can directly edit the settings and we make the feature pain free!

comment:73 Changed 18 months ago by EZdesign (BeezyT)

(In [7460]) refs #2465 improved followingpages.js

  • remember that links have been discovered for hrefs that are not in the following pages
  • check whether using child image for offset fails and use the link instead
  • prevent double-tagging of links the hard way (happens in very rare cases)
  • remove() method didn't unbind window resize event previously which led to behavior that looked like bugs

comment:74 Changed 18 months ago by EZdesign (BeezyT)

The previous commit should fix all bugs the have been reported concerning the bubbles. There still are problems with sliders that rely on a container with overflow:hidden. I won't fix that for now because it would be complicated and expensive (in terms of CPU).

I didn't check in all browsers yet so there still might be browser-related problems.

comment:75 Changed 18 months ago by matt (mattab)

(In [7467]) Refs #2465 Will test on demo

comment:76 in reply to: ↑ 72 Changed 18 months ago by EZdesign (BeezyT)

  • Message can be slightly improved:
    • If the user is admin for the site Piwik::isUserHasAdminAccess($idSite) then the message could link to: module=SitesManager&action=index with hash tag: #row5 for idsite=5 --> this way they can directly edit the settings and we make the feature pain free!

Great idea! The only problem is that #row5 links to fifth row, not the row with idSite=5. So how could else could we link to right row in the table?

comment:77 Changed 18 months ago by EZdesign (BeezyT)

(In [7470]) refs #2465

overlay has two modes now: full screen with sidebar & full screen without sidebar. for now, it is only accessible via a new row action in the pages report.

because of this change, some mostly not-so-nice core-changes could be removed (mainly that's good because overlay doesn't impact as many things outside the plugin anymore):

  • disableHistory option of broadcast
  • handling for parameter overlayUrl in broadcast
  • openLinksInOverlay() method of html table
  • config option overlay_launch_from_pages_report
  • hack for data table to launch overlay from the links

other changes:

  • error message for wrong domain has nice styles and links to admin page when the user has admin privileges
  • when registering row actions, the order can be set
  • made row action style a little more compact
  • increased min width of label column a bit

comment:78 Changed 18 months ago by EZdesign (BeezyT)

(In [7471]) refs #2465

  • simple date selection for sidebar mode
  • code formatter applied (whitespace changes)

comment:79 Changed 18 months ago by EZdesign (BeezyT)

(In [7472]) refs #2465 iframe dimension fix

comment:80 Changed 18 months ago by EZdesign (BeezyT)

(In [7473]) refs #2465

  • row evolution and transitions can be launched from the sidebar
  • when launching overlay, always pick date "current month"
  • make sure there never are two scrollbars when the window is not high enough

comment:81 Changed 18 months ago by EZdesign (BeezyT)

(In [7477]) refs #2465

  • remember the location of the iframe in the l parameter using the core broadcast methods => popoverParam works as well => transitions and row evolution can make use of the back button
  • row evolution and transitions get a static launch method that is used in overlay to trigger the popovers without any knowledge of their implementation
  • broadcast.propagateAjax() gets the disableHistory parameter back but the handling is much easier this time
  • remove full screen link for now because we might want to do that differently - i'll add some details to the ticket later
  • two fixes for sanitized urls

comment:82 Changed 17 months ago by EZdesign (BeezyT)

(In [7479]) refs #2465

  • support for internet explorer 7 & 8
    • redirect by setting window.location.href loses referrer - use fake link
    • implementing position:fixed for status bar in java script
    • when visibility=inherit, go up the dom to find out whether an element is visible
    • avoid .data() completely in followingpages.js
    • some specific html and css
  • adding v parameter to loaded script to invalidate caches
  • regenerating piwik.js (i hope it worked properly this time)
  • hiding notifications that get stuck after removing a hovered element (only happens sometimes)
  • binding window.resize after every broadcast.pageload() - the binding was lost after opening a popover
  • fixing mode with frames disabled: didn't work after migration to the l parameter

This version is the first one that I think is stable. Please deploy on the demo so we can do some more testing.

The next step is translation and documentation. After that, we're ready to release as beta.

comment:83 Changed 17 months ago by EZdesign (BeezyT)

(In [7482]) refs #2465 link new doc page from overlay error message

comment:84 Changed 17 months ago by EZdesign (BeezyT)

  • Description modified (diff)

comment:85 Changed 17 months ago by matt (mattab)

(In [7483]) Refs #2465 Will test on demo

comment:86 Changed 17 months ago by EZdesign (BeezyT)

(In [7486]) refs #2465: using Piwik::isHttps()

comment:87 Changed 17 months ago by matt (mattab)

(In [7493]) Refs #2465
FIxing " The only problem is that #row5 links to fifth row, not the row with idSite=5"

comment:88 Changed 17 months ago by matt (mattab)

(In [7516]) Refs #2465 Will test on demo

comment:89 Changed 17 months ago by matt (mattab)

(In [7519]) Refs #2465 fixing error - but i'm afraid it still not loading on https page on demo.

comment:90 Changed 17 months ago by matt (mattab)

(In [7528]) Refs #2465 Will test on demo - this beta should be fairly stable!

comment:91 Changed 17 months ago by matt (mattab)

(In [7534]) Fixes #3572 Refs #2465 Overlay work on SSL on demo! NICE!

comment:92 Changed 16 months ago by matt (mattab)

  • Description modified (diff)
  • Priority changed from major to critical

See #3530 List of Page Overlay Improvements for more info and the current state of the art!

comment:93 Changed 16 months ago by halfdan

I have a bug (?) report for Page Overlay, sadly Trac blocked my post so I reposted it on pastebin: http://pastebin.com/DtwLvPXi

comment:94 Changed 16 months ago by matt (mattab)

Error is: Strict Notice:</strong> <i>Only variables should be passed by reference</i> in <b>/var/www/htdocs/piwik.c0demonkey.com/html/plugins/Overlay/API.php</b> on line <b>116</b>

comment:95 Changed 16 months ago by matt (mattab)

(In [7712]) Refs #2465 Try fixing notice - does it fix it @halfdan?

comment:96 Changed 16 months ago by matt (mattab)

(In [7713]) Refs #2465 that's better I think

comment:97 Changed 15 months ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

Marking as fixed. Nice work Timo! Hope to see some improvements in Page Overlay later!

Note: See TracTickets for help on using tickets.