Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS and JavaScript loading performance - ideas #2514

Closed
robocoder opened this issue Jun 25, 2011 · 2 comments
Closed

CSS and JavaScript loading performance - ideas #2514

robocoder opened this issue Jun 25, 2011 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

  1. We should either pre-minimize .css and .js files, or use the build script to do so when packaging. This would allow for more aggressive methods that aren't practical at runtime. It also simplifies the AssetManager ... it only has to load and concatenate (which can be done quickly). (Theoretically, we could even generate the compressed files.)
  2. We're concatenating and minifying a lot of JavaScript now. Where possible, we should use a well-known CDN for third-party JavaScript (perhaps as default). This will take some of the load off the server and hopefully increase the chances of loading static assets from the browser's cache.

The problem we have is that the existing use_ajax_cdn code is only accessible by use disable_merged_assets = 1.

  1. We should minify our static content as two separate groups:
    • css and js - independent of which plugins are enabled; this is also the larger group (i.e., jquery, jquery-ui, jqplot)
    • css and js - varies depending on which plugins are enabled
@robocoder
Copy link
Contributor Author

Some ideas if we start refactoring: https://github.com/kriswallsmith/assetic

@mattab
Copy link
Member

mattab commented Dec 14, 2012

Current mechanism seems to work fine so I vote for not changing or adding pre-build logic

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants